Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ecs): Asset ContainerImage no longer takes Construct arguments #2906

Merged
merged 2 commits into from
Jun 18, 2019
Merged

refactor(ecs): Asset ContainerImage no longer takes Construct arguments #2906

merged 2 commits into from
Jun 18, 2019

Commits on Jun 18, 2019

  1. refactor(ecs): ContainerImage no longer takes asset arguments 

    Turn the `ContainerImage` into the standard integration pattern. It is
no longer a construct itself, but creates subconstructs during `bind`.

BREAKING CHANGE:

* **ecs**: `ContainerImage.fromAsset()` now takes only build directory
  directly (no need to pass `scope` or `id` anymore).
    @rix0rrr
    rix0rrr committed Jun 18, 2019
    Configuration menu
    Copy the full SHA
    0c25443 View commit details
    Browse the repository at this point in the history

  2. Update expectations

    @rix0rrr
    rix0rrr committed Jun 18, 2019
    Configuration menu
    Copy the full SHA
    2c8b374 View commit details
    Browse the repository at this point in the history