Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pipes-enrichments): new EventBridge Pipes enrichments alpha module #29063

Merged

Conversation

RaphaelManke
Copy link
Contributor

Issue # (if applicable)

Closes #.

Reason for this change

This PR adds a new alpha module to for EvenBridge pipes enrichments.

This is the base setup for future work and additional enrichments.

Description of changes

The initial enrichment is the Lambda enrichment.

Description of how you validated changes

  • Unittests
  • Integration test

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
RaphaelManke Raphael Manke
@aws-cdk-automation aws-cdk-automation requested a review from a team February 10, 2024 12:18
@github-actions github-actions bot added p2 repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK labels Feb 10, 2024

Verified

This commit was signed with the committer’s verified signature.
RaphaelManke Raphael Manke

Verified

This commit was signed with the committer’s verified signature.
RaphaelManke Raphael Manke
@RaphaelManke RaphaelManke marked this pull request as ready for review February 10, 2024 12:26

Verified

This commit was signed with the committer’s verified signature.
RaphaelManke Raphael Manke
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Feb 10, 2024
packages/@aws-cdk/aws-pipes-enrichments-alpha/README.md Outdated Show resolved Hide resolved
});
});

it('should have only enrichment arn', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think using it is fine but elsewhere in CDK we have been using test and we may eventually want parity if/when we stabilize this module.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @RaphaelManke!

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Feb 13, 2024
Copy link
Contributor

mergify bot commented Feb 13, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 3e869bc
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 5a54ec5 into aws:main Feb 13, 2024
9 checks passed
Copy link
Contributor

mergify bot commented Feb 13, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

GavinZZ pushed a commit that referenced this pull request Feb 22, 2024
…le (#29063)

### Issue # (if applicable)

Closes #<issue number here>.

### Reason for this change

This PR adds a new alpha module to for EvenBridge pipes enrichments.

This is the base setup for future work and additional enrichments.

### Description of changes

The initial enrichment is the Lambda enrichment.

### Description of how you validated changes

- [x] Unittests
- [x] Integration test


### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2 repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants