Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stepfunctions): maxConcurrency does not support JsonPath #29330

Merged
merged 5 commits into from
Mar 2, 2024

Conversation

abdelnn
Copy link
Contributor

@abdelnn abdelnn commented Mar 1, 2024

Issue # (if applicable)

Relates to #20835

Reason for this change

MaxConcurrency does not support JsonPath. This change adds MaxConcurrencyPath so that CDK users can specify a JsonPath for their MaxConcurrency

Note : This does not invalidate JsonPaths for MaxConcurrency, as I'm unsure how to do so without reverting #20279 . Open to suggestions

Description of changes

Added a new maxConcurrencyPath field that accepts a JsonPath value. Decided to go with another explicit field as it is similar to what is done for ErrorPath and CausePath, in addition to most other Path fields

Description of how you validated changes

Added unit tests

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 labels Mar 1, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team March 1, 2024 05:59
@abdelnn abdelnn marked this pull request as ready for review March 1, 2024 06:45
Copy link
Contributor

@wong-a wong-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments. LGTM overall

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 1, 2024
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 1, 2024
Copy link
Contributor

@aaythapa aaythapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, changes look good!

This does not invalidate JsonPaths for maxConcurrency, as I'm unsure how to do so without reverting #20279 . Open to suggestions

I'd suggest the same thing Kaizen suggested here and throw a descriptive error when we detect a JSON path in maxConcurrency. Should be backwards compatible as the deployment fails.

EDIT: will deal with JSON path in maxConcurrency separately. Merging this PR for now so that people with the same issue as #20835 have a workaround

aaythapa
aaythapa previously approved these changes Mar 2, 2024
@mergify mergify bot dismissed aaythapa’s stale review March 2, 2024 00:31

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: bcb24b1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Mar 2, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit b19f822 into aws:main Mar 2, 2024
11 checks passed
@abdelnn abdelnn deleted the maxConcurrencyJsonPath branch April 23, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants