Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(codepipeline): add missing action for EcsDeployAction #29401

Merged
merged 4 commits into from
Mar 8, 2024

Conversation

pahud
Copy link
Contributor

@pahud pahud commented Mar 7, 2024

Issue # (if applicable)

Closes #29400

Reason for this change

Missing required action as described from the doc.

Description of changes

Description of how you validated changes

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort p2 labels Mar 7, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team March 7, 2024 16:56
@pahud pahud added the pr/do-not-merge This PR should not be merged at this time. label Mar 7, 2024
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Mar 7, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@pahud pahud changed the title WIP - fix(codepipeline): add missing action for EcsDeployAction fix(codepipeline): add missing action for EcsDeployAction Mar 7, 2024
@pahud pahud changed the title fix(codepipeline): add missing action for EcsDeployAction chore(codepipeline): add missing action for EcsDeployAction Mar 7, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review March 7, 2024 17:24

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@pahud pahud changed the title chore(codepipeline): add missing action for EcsDeployAction fix(codepipeline): add missing action for EcsDeployAction Mar 7, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@pahud pahud changed the title fix(codepipeline): add missing action for EcsDeployAction chore(codepipeline): add missing action for EcsDeployAction Mar 7, 2024
@pahud pahud marked this pull request as ready for review March 7, 2024 21:44
@pahud pahud removed the pr/do-not-merge This PR should not be merged at this time. label Mar 7, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review March 7, 2024 21:45

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Mar 7, 2024
@pahud pahud added p1 and removed p2 labels Mar 7, 2024
@pahud pahud requested a review from paulhcsun March 8, 2024 00:01
@pahud
Copy link
Contributor Author

pahud commented Mar 8, 2024

@paulhcsun All addressed please take a look again.

Copy link
Contributor

@paulhcsun paulhcsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @pahud!

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 043dc9a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Mar 8, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 946412b into aws:main Mar 8, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. effort/small Small work item – less than a day of effort p1 pr/needs-maintainer-review This PR needs a review from a Core Team Member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

codepipeline: EcsDeployAction missing ecs:TagResource
3 participants