Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ecs): set default HealthCheckGracePeriodSeconds #2942

Merged
merged 6 commits into from
Jun 21, 2019
Merged

feat(ecs): set default HealthCheckGracePeriodSeconds #2942

merged 6 commits into from
Jun 21, 2019

Commits on Jun 19, 2019

  1. feat(ecs): set the default HealthCheckGracePeriodSeconds in base-se… 

    …rvice to 60 seconds if it's not already set and at least one load balancer is configured

This was a FIXME in the ECS CDK codebase.

Closes #2936.
    @hencrice
    hencrice committed Jun 19, 2019
    Configuration menu
    Copy the full SHA
    3ca7720 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2019

  1. Fixed formatting issue.

    @hencrice
    hencrice committed Jun 20, 2019
    Configuration menu
    Copy the full SHA
    633b527 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into baseservice-fixme 

    # Conflicts:
#	packages/@aws-cdk/aws-ecs/lib/base/base-service.ts
    @hencrice
    hencrice committed Jun 20, 2019
    Configuration menu
    Copy the full SHA
    596e9cb View commit details
    Browse the repository at this point in the history

  3. Moved the logic that determines the value of `healthCheckGracePeriodS… 

    …econds` into a private helper method as requested
    @hencrice
    hencrice committed Jun 20, 2019
    Configuration menu
    Copy the full SHA
    9072363 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2019

  1. Merge remote-tracking branch 'origin/master' into pr/hencrice/2942

    @rix0rrr
    rix0rrr committed Jun 21, 2019
    Configuration menu
    Copy the full SHA
    73e37d0 View commit details
    Browse the repository at this point in the history

  2. Simplify evaluator, update expectations

    @rix0rrr
    rix0rrr committed Jun 21, 2019
    Configuration menu
    Copy the full SHA
    d0d1ec0 View commit details
    Browse the repository at this point in the history