Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(route53-patterns): cross region references with HttpsRedirect #29464

Closed

Conversation

andreialecu
Copy link
Contributor

Issue #29453

Closes #29453

Reason for this change

@aws-cdk/aws-route53-patters:useCertificate flag did not work properly in some cases.

Description of changes

Enable crossRegionReferences

Description of how you validated changes

This doesn't currently work because it results in:

Error: 'integ-https-redirect' depends on 'certificate-redirect-stack-c8dcaeced090b732e39f9a17bfcca0bf8d20ce4f61' (integ-https-redirect -> certificate-redirect-stack-c8dcaeced090b732e39f9a17bfcca0bf8d20ce4f61/RedirectCertificatec8615644f6b8e5372f779988c9aad3c31ec249ee76/Resource.Ref). Adding this dependency (certificate-redirect-stack-c8dcaeced090b732e39f9a17bfcca0bf8d20ce4f61 -> integ-https-redirect/HostedZone/Resource.Ref) would create a cyclic reference.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

hostedZoneId,
zoneName: hostedZoneName,
});
const hostedZone = new HostedZone(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Results in

Error: 'integ-https-redirect' depends on 'certificate-redirect-stack-c8dcaeced090b732e39f9a17bfcca0bf8d20ce4f61' (integ-https-redirect -> certificate-redirect-stack-c8dcaeced090b732e39f9a17bfcca0bf8d20ce4f61/RedirectCertificatec8615644f6b8e5372f779988c9aad3c31ec249ee76/Resource.Ref). Adding this dependency (certificate-redirect-stack-c8dcaeced090b732e39f9a17bfcca0bf8d20ce4f61 -> integ-https-redirect/HostedZone/Resource.Ref) would create a cyclic reference.

@andreialecu
Copy link
Contributor Author

Any guidance on how to fix the cyclic reference would be appreciated.

Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 0343f41
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@aws-cdk-automation
Copy link
Collaborator

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

@aws-cdk-automation aws-cdk-automation added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label Apr 11, 2024
@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ Fixes must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. p2 repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK
Projects
None yet
2 participants