Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(elasticloadbalancerV2): logicalId supports switch from addTargetGroups (under feature flag) #29513

Merged
merged 14 commits into from
Apr 3, 2024
Merged

fix(elasticloadbalancerV2): logicalId supports switch from addTargetGroups (under feature flag) #29513

merged 14 commits into from
Apr 3, 2024

Commits on Mar 26, 2024

  1. fix(ElasticLoadBalancerV2): consistent logicalIds (under feature flag)

    @ahammond
    ahammond committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    90c518e View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2024

  1. fix comment to match feature flag names

    @ahammond
    ahammond committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    086d2f4 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2024

  1. Update packages/aws-cdk-lib/cx-api/README.md 

    Co-authored-by: paulhcsun <47882901+paulhcsun@users.noreply.github.com>
    @ahammond @paulhcsun
    ahammond and paulhcsun committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    4ad1095 View commit details
    Browse the repository at this point in the history

  2. Update packages/aws-cdk-lib/cx-api/lib/features.ts 

    Co-authored-by: paulhcsun <47882901+paulhcsun@users.noreply.github.com>
    @ahammond @paulhcsun
    ahammond and paulhcsun committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    562b4a6 View commit details
    Browse the repository at this point in the history

  3. Update packages/aws-cdk-lib/cx-api/lib/features.ts 

    Co-authored-by: paulhcsun <47882901+paulhcsun@users.noreply.github.com>
    @ahammond @paulhcsun
    ahammond and paulhcsun committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    06bdfe5 View commit details
    Browse the repository at this point in the history

  4. Update packages/aws-cdk-lib/cx-api/lib/features.ts 

    Co-authored-by: paulhcsun <47882901+paulhcsun@users.noreply.github.com>
    @ahammond @paulhcsun
    ahammond and paulhcsun committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    c83bac6 View commit details
    Browse the repository at this point in the history

  5. Update packages/aws-cdk-lib/cx-api/lib/features.ts 

    Co-authored-by: paulhcsun <47882901+paulhcsun@users.noreply.github.com>
    @ahammond @paulhcsun
    ahammond and paulhcsun committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    7a8ee82 View commit details
    Browse the repository at this point in the history

  6. Update packages/aws-cdk-lib/cx-api/lib/features.ts 

    Co-authored-by: paulhcsun <47882901+paulhcsun@users.noreply.github.com>
    @ahammond @paulhcsun
    ahammond and paulhcsun committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    c6d1de3 View commit details
    Browse the repository at this point in the history

  7. address comments

    @ahammond
    ahammond committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    440cb4e View commit details
    Browse the repository at this point in the history

  8. fix tests

    @ahammond
    ahammond committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    d6417c1 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'main' into logicalId-consistency

    @ahammond
    ahammond committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    c8b1504 View commit details
    Browse the repository at this point in the history

  10. correctly revert the change for addTargetGroups

    @ahammond
    ahammond committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    c737e4b View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2024

  1. Update packages/aws-cdk-lib/cx-api/lib/features.ts 

    Add linebreak
    @paulhcsun
    paulhcsun committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    b743db6 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into logicalId-consistency

    @mergify
    mergify[bot] committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    28fcdbe View commit details
    Browse the repository at this point in the history