-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(lambda-nodejs): unescaped whitespace in props.bundling.inject breaks esbuild #29561
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
@bombguy possible to add an integration test for this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making this change! +1 to adding integration tests then we can merge it in
can you point me to where the integration tests are for this package? |
bundling: { | ||
inject: [path.join(__dirname, 'whitespace path/shim.js')], | ||
}, | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bombguy Did this not result in a snapshot change?
hi @bombguy, looks like some snapshots changed which is causing the build failure. You can use |
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Issue # (if applicable)
Closes #29559 .
Reason for this change
NodejsFunction fails to build in projects with spaces in path
Description of changes
Updated how it maps esbuild arguments from bundling props
Description of how you validated changes
Tried building the NodejsFunction
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license