Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lambda-nodejs): unescaped whitespace in props.bundling.inject breaks esbuild #29561

Merged
merged 8 commits into from
Apr 16, 2024

Conversation

bombguy
Copy link
Contributor

@bombguy bombguy commented Mar 20, 2024

Issue # (if applicable)

Closes #29559 .

Reason for this change

NodejsFunction fails to build in projects with spaces in path

Description of changes

Updated how it maps esbuild arguments from bundling props

Description of how you validated changes

Tried building the NodejsFunction

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. p2 labels Mar 20, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team March 20, 2024 16:51
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@bombguy bombguy changed the title fixing unescaped whitespace in props.bundling.inject fix(aws-lambda-nodejs) unescaped whitespace in props.bundling.inject breaks esbuild Mar 20, 2024
@bombguy bombguy changed the title fix(aws-lambda-nodejs) unescaped whitespace in props.bundling.inject breaks esbuild chore(aws-lambda-nodejs) unescaped whitespace in props.bundling.inject breaks esbuild Mar 20, 2024
@bombguy bombguy changed the title chore(aws-lambda-nodejs) unescaped whitespace in props.bundling.inject breaks esbuild chore(aws-lambda-nodejs): unescaped whitespace in props.bundling.inject breaks esbuild Mar 20, 2024
@bombguy bombguy changed the title chore(aws-lambda-nodejs): unescaped whitespace in props.bundling.inject breaks esbuild chore(lambda-nodejs): unescaped whitespace in props.bundling.inject breaks esbuild Mar 20, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review March 20, 2024 21:52

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 20, 2024
@msambol
Copy link
Contributor

msambol commented Mar 21, 2024

@bombguy possible to add an integration test for this?

Copy link
Contributor

@aaythapa aaythapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this change! +1 to adding integration tests then we can merge it in

@bombguy
Copy link
Contributor Author

bombguy commented Mar 25, 2024

@bombguy possible to add an integration test for this?

can you point me to where the integration tests are for this package?

@aaythapa
Copy link
Contributor

@bombguy possible to add an integration test for this?

can you point me to where the integration tests are for this package?

I'd assume here, you can find out how to make and run integ tests using this doc

bundling: {
inject: [path.join(__dirname, 'whitespace path/shim.js')],
},
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bombguy Did this not result in a snapshot change?

@aaythapa
Copy link
Contributor

aaythapa commented Apr 4, 2024

hi @bombguy, looks like some snapshots changed which is causing the build failure. You can use yarn integ --update-on-failed to re-make the snapshots

@bombguy
Copy link
Contributor Author

bombguy commented Apr 16, 2024

yarn integ --update-on-failed was failing due to bad build artifacts. I was able to update the snapshots after a clean build

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 43f62a8
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Apr 16, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 72b6d8e into aws:main Apr 16, 2024
10 checks passed
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Apr 16, 2024
@bombguy bombguy deleted the patch-1 branch April 16, 2024 22:49
@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws-lambda-nodejs: incorrectly maps esbuild arguments when there is whitespace in path for inject
5 participants