chore(opensearchservice): t3 instance type does not support Multi-AZ with standby feature

[tmokmss]

Issue # (if applicable)

Related with #26026

Reason for this change

#26082 enabled Multi-AZ with Standby by default, but deployment fails if we use t3 instance type, because it does not support the feature. To fail fast, this PR adds validation on synth time.

Multi-AZ with Standby only works with the m5, c5, r5, r6g, c6g, m6g, r6gd and i3 instance types.
https://docs.aws.amazon.com/opensearch-service/latest/developerguide/managedomains-multiaz.html

You can use T3 instance types only if your domain is provisioned without standby.
https://docs.aws.amazon.com/opensearch-service/latest/developerguide/supported-instance-types.html#latest-gen

Description of changes

If the instance type of data node or master node is t3, throws an error.

I also considered to automatically set multiAzWithStandbyEnabled: false if we detect any t3 instance type, but it would introduce unwanted behavior e.g. in the below case:

// Initial state
// multiAzWithStandbyEnabled: true as there's no t3 instance type
 new Domain(stack, 'Domain', {
    version: engineVersion,
    capacity: {
      dataNodeInstanceType: 'r5.large.search',
    },
})

// Update domain to add master nodes with t3 instance type
new Domain(stack, 'Domain', {
    version: engineVersion,
    capacity: {
      dataNodeInstanceType: 'r5.large.search',
      masterNodeInstanceType: 't3.medium.search',
      masterNodes: 3,
    },
})

// multiAzWithStandbyEnabled suddenly become false!

so we just throw an error.

Description of how you validated changes

Added some unit tests.

I also confirmed that it results in deployment error if we try to deploy with t3 instance type & multiAzWithStandbyEnabled : true for both data node and master node.

Checklist

• My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

[go-to-k]

From what I can see in the management console, OR1 and Im4gn instance types are apparently supported in the Multi-AZ with standby as well.

I selected "Domain with standby" and was able to select both OR1 and Im4gn. I also confirmed that t3 cannot be selected for "Domain with standby", and the t3 can be selected for "Domain without standby" (with the "Include previous generation instance types" toggle).

(Note that I did not actually create the domain.)

#26026 (comment)

[tmokmss]

Thanks @go-to-k!

[go-to-k]

LGTM. Thanks @tmokmss

[GavinZZ]

LGTM, thanks for contributing.

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: 2c4596d
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).