-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(glue): adds timeout and workerType validation for Ray jobs #29613
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
Exemption Request: this change only affects construct validation, so I don't think there is anything testable with integration / snapshot tests - please advise if I am misunderstanding something here though, this is my first contribution. |
There is actually a group working on redesigning some of the rough edges in this module. I'd like to make sure that any changes we take doesn't cause code conflicts with their work so I'm going to add the do-not-merge label to this while I discuss with them. |
This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
The pull request linter fails with the following errors:
PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing ✅ A exemption request has been requested. Please wait for a maintainer's review. |
@TheRealAmazonKendra Any updates from the Glue team on if this is a PR they are interested in taking? Looks like this was closed for staleness today, but I can reopen (resubmit?) if this is something that has a chance of landing. |
Issue
Closes #29612
Reason for this change
In the course of building some Ray on Glue jobs, I ran into deployment failures both from specifying a timeout and from not specifying a worker type. In both cases, the construct synthesizes, but fails to deploy - see the linked issue for a small reproduction.
I opened the above linked issue, which this PR addresses.
Description of changes
This change introduces two new validations to the constructor of
Job
from@aws-cdk/aws-glue-alpha
:Z_2X
- to deploy, this may not be null and must beZ_2X
Description of how you validated changes
I added three new unit tests to the other constructor validation tests in
job.test.ts
, underJob -> new -> ray job
:timeout
will throw an errorworkerType
workerType
other thatZ_2X
will throw an errorFrom my local machine, I validated these changes with
yarn build
andyarn test
, as well as linking the updated package into my repro sample package and manually testing. Additionally, I ranyarn lint
and confirmed there were no outstanding format issues.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license