chore(lambda): upgrade default runtime for custom resource provider and function to nodejs_20

[shikha372]

Issue # (if applicable)

Closes: #28125
Tracking Ticket: #29786

Reason for this change

Keeping dependencies up to date with latest release in custom resource provider function and lambda default runtime value for Nodejs

Description of changes

Update default runtime defined in HandlerFrameworkModule to update custom resource provider
Update runtime for custom resource provider still using CfnResource.
Update for providers in alpha modules.
Unit Test updated with expected runtime value
Update to expected runtime value in integ test along with snapshots.

Description of how you validated changes

Ran Integration Tests(framework-integ) to validate custom resources behaviour after the upgrade.

Checklist

• My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[GavinZZ]

Curious how do you confirm that we didn't miss anywhere?

[shikha372]

how do you confirm that we didn't miss anywhere?

ran yarn build and yarn test on local under aws-cdk-lib and @aws-cdk/custom-resource-handlers to confirm that unit tests are passing, changes to the unit tests are confirmed on the basis of that.
Also, we verify the generated providers created under aws-cdk-lib and aws-cdk dist folder on running build, these generated handlers have nodejs20 as their runtime providers.
example path: ~/aws-cdk/packages/@aws-cdk/custom-resource-handlers/dist/aws-cloudfront/cross-region-string-param-reader-provider.generated.ts
Second verification will be with the below command under each of this package to confirm nodejs18 is mentioned only in expected places
grep -irl 'nodejs18' or grep -irl 'NODEJS_18_X'

[colifran]

Looks good so far! You may be working on it but this should be included too -

aws-cdk/packages/@aws-cdk/integ-tests-alpha/lib/assertions/providers/provider.ts

Line 81 in 00e8a7b

Runtime: 'nodejs18.x',

[shikha372]

Looks good so far! You may be working on it but this should be included too -

aws-cdk/packages/@aws-cdk/integ-tests-alpha/lib/assertions/providers/provider.ts

Line 81 in 00e8a7b

Runtime: 'nodejs18.x',

Added in latest commit

[TheRealAmazonKendra]

Just a couple of comments but overall I think this is looking good so far. One quick question I have is what the scope of this task is intended to be. We have some testing infra that is likely hardcoded to node18 (not meaning the framework integ tests that I had asked to be split out, other places). So, fi this change is meant to be exhaustive for the repo, some things may have been missed.

[TheRealAmazonKendra]

Just one quick comment

[TheRealAmazonKendra]

As long as all the integ tests pass, we should be good.

[TheRealAmazonKendra]

Well, I've got some unfortunate news, I was searching for something unrelated to this change and discovered that node20 isn't available in GovCloud, ADC, or China regions so in places where DEFAULT was specifying node18 and anywhere that the version is not configurable to the user still needs to be that.

[colifran]

@TheRealAmazonKendra Given that news it seems like moving forward here doesn't make sense until node20 is available in GovCloud, ADC, and China regions.

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: b309d11
• Result: FAILED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[aws-cdk-automation]

Updating this to requesting changes as Node20 ins not available in all partitions.

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

[github-actions]

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.