Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(s3): autoDeleteObjects log group allows retention period and removal policy definitions #29698

Closed
wants to merge 31 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
04fd661
autodeleteobjects log group auto deletes too
kishiel Mar 29, 2024
54881be
aws-s3 snapshots
kishiel Mar 29, 2024
a52330e
bunch of snapshots
kishiel Mar 29, 2024
5665968
most of the codepipeline-actions
kishiel Mar 29, 2024
ea30942
dynamodb snapshot
kishiel Mar 29, 2024
6ccf4e5
most ec2 snapshots
kishiel Mar 30, 2024
b7b7ab0
ecr snapshot
kishiel Mar 30, 2024
9e7ac35
most ecs snapshots
kishiel Mar 30, 2024
47d4eda
efs snapshots
kishiel Mar 30, 2024
f66c3f8
global accelerator snapshot
kishiel Mar 30, 2024
f2c165a
iam snapshots
kishiel Mar 30, 2024
b09bfd9
lambda snapshots
kishiel Mar 30, 2024
58d4697
lambda sources snapshots
kishiel Mar 30, 2024
d8233a6
most rds snapshots
kishiel Mar 30, 2024
f33d15b
s3-deployment snapshots
kishiel Mar 30, 2024
3700338
s3-notifications snaphots
kishiel Mar 30, 2024
433e039
stepfunctions and others
kishiel Mar 30, 2024
1ecb0c9
core snapshot
kishiel Mar 30, 2024
0bf9617
most pipelines snapshots
kishiel Mar 30, 2024
98173cf
triggers snapshot
kishiel Mar 30, 2024
2bfe2ae
update synthetics runtime versions and snapshots
kishiel Mar 30, 2024
14b7f5f
most eks snapshots
kishiel Mar 31, 2024
b1508a8
update deprecated engine and instance type, snaphots
kishiel Apr 1, 2024
0aa989f
remaining ec2 snapshot
kishiel Apr 1, 2024
8d0268f
last ecs snapshot
kishiel Apr 1, 2024
1b015c2
update snapshots
kishiel Apr 2, 2024
bebf1b2
update readme
kishiel Apr 2, 2024
17ecbb0
fix core tests
kishiel Apr 3, 2024
32bcec8
Merge branch 'main' into s3_autodelete_log_fix
kishiel Apr 3, 2024
3ba5f5c
run asset test earlier
kishiel Apr 5, 2024
d659009
kinesisfirehose snapshot
kishiel Apr 5, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

This file was deleted.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,14 @@
"UpdateReplacePolicy": "Delete",
"DeletionPolicy": "Delete"
},
"BucketautodeletionloggroupAE7EF139": {
"Type": "AWS::Logs::LogGroup",
"Properties": {
"RetentionInDays": 90
},
"UpdateReplacePolicy": "Delete",
"DeletionPolicy": "Delete"
},
"BucketPolicyE9A3008A": {
"Type": "AWS::S3::BucketPolicy",
"Properties": {
Expand Down Expand Up @@ -103,6 +111,21 @@
{
"Fn::Sub": "arn:${AWS::Partition}:iam::aws:policy/service-role/AWSLambdaBasicExecutionRole"
}
],
"Policies": [
{
"PolicyName": "Inline",
"PolicyDocument": {
"Version": "2012-10-17",
"Statement": [
{
"Effect": "Deny",
"Action": "logs:CreateLogGroup",
"Resource": "*"
}
]
}
}
]
}
},
Expand All @@ -113,11 +136,16 @@
"S3Bucket": {
"Fn::Sub": "cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}"
},
"S3Key": "2ec8ad9e91dcd6e7ad6a5c84ffc6c9c05c408aca3b26ceb2816d81043e6c4dc3.zip"
"S3Key": "54e6f07bf3aea46d100719f3b21fe0fb45ae789ee372d42d8cdfb97e21aba96c.zip"
},
"Timeout": 900,
"MemorySize": 128,
"Handler": "index.handler",
"LoggingConfig": {
"LogGroup": {
"Ref": "BucketautodeletionloggroupAE7EF139"
}
},
"Role": {
"Fn::GetAtt": [
"CustomS3AutoDeleteObjectsCustomResourceProviderRole3B1BD092",
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading