-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(elasticloadbalancingv2): set proper default for stickiness #29726
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, matches the behavior:
aws-cdk/packages/aws-cdk-lib/aws-elasticloadbalancingv2/lib/alb/application-target-group.ts
Lines 340 to 344 in e52510c
if (props.stickinessCookieDuration) { | |
this.enableCookieStickiness(props.stickinessCookieDuration, props.stickinessCookieName); | |
} else { | |
this.setAttribute('stickiness.enabled', 'false'); | |
} |
I die on the inside a little every time I see this https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk-lib/aws-elasticloadbalancingv2/lib/alb/application-target-group.ts#L73
But, that's not your change. Yours is good. Thanks for fixing that. I'm going to rename this a docs change for better clarity on what was updated. |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one. |
By default, stickiness is disabled. The duration is one day if stickiness is enabled,
but we don't surface that option to users. If
stickinessCookieDuration
is notsupplied, stickiness will not be enabled so the 1 day default doesn't make sense here.
Closes #29725.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license