docs(ecr-assets): fixes documentation for cross-account access to dockerImageAsset ECR repository #29766
Conversation
In cdkv2, it is no longer possible to add permissions on the repository for `dockerImageAsset`, but the docs were not updated. Updates documentation for aws-ecr-assets. Mentions that it is no longer possible to grant repository permissions on `dockerImageAsset` for cross-account access and provides possible alternate routes. Rebuilt doc change. - [X] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
github-actions
bot
added
beginning-contributor
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
nickgardner-amazon
changed the title
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
aws-cdk-automation
added
the
pr/needs-community-review
|
@TheRealAmazonKendra This is the docs change I mentioned making. Only bit I went back and forth on was whether to mention the possibility of modifying the CDK bootstrap stack. It's not an ideal solution but as far as I know it's the only one that lets you still use the asset directly without copying it somehow. |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
aws-cdk-automation
removed
the
pr/needs-community-review
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one. |
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
Issue # (if applicable)
#13327 (Only a docs update, does not fix the underlying issue)
Reason for this change
In cdkv2, it is no longer possible to add permissions on the repository for
dockerImageAsset, but the docs were not updated.Description of changes
Updates documentation for aws-ecr-assets. Mentions that it is no longer possible to grant repository permissions on
dockerImageAssetfor cross-account access and provides possible alternate routes.Description of how you validated changes
Rebuild the affected doc.
No, docs change only
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license