-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ec2): NatInstanceProviderV2
security group example
#29769
Conversation
@arachnilith Can you confirm that this covers the feature request you raised in #27527? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for making the change.
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one. |
Issue # (if applicable)
Closes #27527
Reason for this change
The current
NatInstanceProviderV2.securityGroup
property is unusable, given the dependency loop between the construct props (NatInstanceProviderV2
>VPC
>SecurityGroup
>NatInstanceProviderV2
).When creating the integration for #29729, adding a getter for the instances generated by the provider to update the instance role was required to test the
userData
overload. This solution also allows to bypass the circular dependency describe above, given that both the VPC and the instances are generated once the VPC is created with thenatGatewayProvider
.Description of changes
NatInstanceProviderV2.securityGroup
@example
tag to demoNatInstanceProviderV2.gatewayInstances
README
to demo setting the security groupDescription of how you validated changes
Updated integration test
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license