Skip to content

Conversation

@piradeepk
Copy link
Contributor

@piradeepk piradeepk commented Jun 21, 2019

Make cluster name private in BaseService and remove redundant property cluster name in Ec2Service.

  • Existing unit tests and integration tests pass.
  • Pull clusterName from the cluster instead of passing it in.
  • BREAKING CHANGE: clusterName can no longer be accessed externally from BaseService, Ec2Service or FargateService.

Pull Request Checklist

  • Testing
    • Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change)
    • CLI change?: coordinate update of integration tests with team
    • cdk-init template change?: coordinated update of integration tests with team
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
    • Design: For significant features, design document added to design folder
  • Title and Description
    • Change type: title prefixed with fix, feat and module name in parens, which will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

@piradeepk piradeepk requested review from a team and SoManyHs as code owners June 21, 2019 01:03
@piradeepk
Copy link
Contributor Author

@rix0rrr please review

@rix0rrr rix0rrr self-assigned this Jun 21, 2019
@rix0rrr
Copy link
Contributor

rix0rrr commented Jun 21, 2019

And so the build failure tells us that clusterName is used by the EcsDeployAction.

@rix0rrr rix0rrr merged commit a6e4f6a into aws:master Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants