Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add bergjaak to mergify and merit badger #30006

Merged
merged 2 commits into from
Apr 29, 2024
Merged

Conversation

bergjaak
Copy link
Contributor

@bergjaak bergjaak commented Apr 29, 2024

Reason for this change

Adding myself to the contributors

Description of changes

Adding myself to the contributors

Description of how you validated changes

Made sure to spell my name right

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 labels Apr 29, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team April 29, 2024 22:25
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@colifran colifran changed the title Bergjaak onboarding chore: chore: added bergjaak to mergify and merit badger Apr 29, 2024
@colifran colifran changed the title chore: chore: added bergjaak to mergify and merit badger chore: added bergjaak to mergify and merit badger Apr 29, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review April 29, 2024 22:29

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 97c2334
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Apr 29, 2024
Copy link
Contributor

@colifran colifran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome!

Copy link
Contributor

mergify bot commented Apr 29, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@colifran colifran changed the title chore: added bergjaak to mergify and merit badger chore: add bergjaak to mergify and merit badger Apr 29, 2024
@bergjaak bergjaak merged commit af7dcff into main Apr 29, 2024
38 of 41 checks passed
@bergjaak bergjaak deleted the bergjaak-onboarding branch April 29, 2024 23:02
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Apr 29, 2024
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Apr 29, 2024
This was referenced May 1, 2024
@aws-cdk-automation
Copy link
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants