-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(lambda): hide warning if skipPermissions is set #30060
Conversation
If an user imports a lambda and wants to add permissions a warning is show. This warning should be skippable with the skipPermissions flag.
Exemption request - In my opinion this change neither needs an integration test nor an entry to the README. |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one. |
Issue #29887
Closes #29887
Reason for this change
If an user imports a lambda and wants to add permissions a warning is show. This warning should be skippable with the skipPermissions flag.
Description of how you validated changes
Unit tests for checking if the warning is shown/not shown depending on the value of
skipPermissions
are added.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license