-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(codebuild): add missing types for webhook filters #30064
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
Exemption Request: I need a GitHub access token to update the integration test: Could not find access token for server type github. I think it's OK with no integration test update as I'm only adding enum values. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add an integ test for these enums? The integ tests helps prevent regressions.
See my exemption request above. I think I need an access token? Happy to, but CDK core team might need to run it? |
@comcalvi The webhooks are only available on GitHub and BitBucket. I looked at doing an integration test with CodeCommit, but not possible here. Let me know how you want to proceed. |
If the only integration test we can add is one that can't be deployed reliably, then I think it's safe to skip the integ test for this one. Thanks both, I think we can leave the integ test off of this one. |
@comcalvi changes made as requested 👍🏼 |
@comcalvi gentle nudge 😄 |
@comcalvi Do I need to do something further to push this through? |
This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
@comcalvi Could we push this one through before it gets closed? |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one. |
The full list is found here.
Closes #30062.