Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(neptune): add copyTagsToSnapshot property to the DatabaseCluster Construct #30092

Merged
merged 7 commits into from
May 27, 2024

Conversation

mazyu36
Copy link
Contributor

@mazyu36 mazyu36 commented May 7, 2024

Issue # (if applicable)

Closes #30087

Reason for this change

As described in the issue.

Description of changes

Add copyTagsToSnapshot property to the DatabaseCluster Construct.

Description of how you validated changes

Add both unit tests and integ tests.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team May 7, 2024 16:15
@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK feature-request A feature should be added or improved. p2 labels May 7, 2024
@mazyu36 mazyu36 changed the title feat(docdb): add copyTagsToSnapshot property to the DatabaseCluster Construct feat(neptune): add copyTagsToSnapshot property to the DatabaseCluster Construct May 7, 2024
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label May 7, 2024
Copy link
Contributor

@go-to-k go-to-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR. I just made minor comments.

packages/@aws-cdk/aws-neptune-alpha/lib/cluster.ts Outdated Show resolved Hide resolved
@@ -31,6 +31,7 @@ To set up a Neptune database, define a `DatabaseCluster`. You must always launch
const cluster = new neptune.DatabaseCluster(this, 'Database', {
vpc,
instanceType: neptune.InstanceType.R5_LARGE,
copyTagsToSnapshot: true // whether to save the cluster tags when creating the snapshot.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems unnatural to have this property here, which is the most basic chapter. How about creating a new chapter like the Automatic minor version upgrades?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a new chapter about copyTagsSnapshot.

packages/@aws-cdk/aws-neptune-alpha/test/cluster.test.ts Outdated Show resolved Hide resolved
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label May 15, 2024

const app = new cdk.App();

const stack = new cdk.Stack(app, 'aws-cdk-neptune-integ');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to change the stack name so that the integ test can be deployed in parallel with other tests.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the stack name.

mazyu36 and others added 4 commits May 15, 2024 21:57
Co-authored-by: k.goto <24818752+go-to-k@users.noreply.github.com>
Co-authored-by: k.goto <24818752+go-to-k@users.noreply.github.com>
@mazyu36
Copy link
Contributor Author

mazyu36 commented May 15, 2024

@go-to-k
Thank you for your review!
I've addressed all your comments.

Copy link
Contributor

@go-to-k go-to-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your changes. Looks good!

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label May 15, 2024
Copy link
Contributor

@GavinZZ GavinZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

mergify bot commented May 27, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label May 27, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 888c00c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit ba8edb3 into aws:main May 27, 2024
12 checks passed
Copy link
Contributor

mergify bot commented May 27, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mazyu36 mazyu36 deleted the neptune-copytags-30087 branch May 28, 2024 00:22
atanaspam pushed a commit to atanaspam/aws-cdk that referenced this pull request Jun 3, 2024
… Construct (aws#30092)

### Issue # (if applicable)

Closes aws#30087 

### Reason for this change
As described in the issue.



### Description of changes
Add copyTagsToSnapshot property to the DatabaseCluster Construct.


### Description of how you validated changes
Add both unit tests and integ tests.


### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
vdahlberg pushed a commit to vdahlberg/aws-cdk that referenced this pull request Jun 10, 2024
… Construct (aws#30092)

### Issue # (if applicable)

Closes aws#30087 

### Reason for this change
As described in the issue.



### Description of changes
Add copyTagsToSnapshot property to the DatabaseCluster Construct.


### Description of how you validated changes
Add both unit tests and integ tests.


### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@aws-cdk-automation
Copy link
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK feature-request A feature should be added or improved. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(neptune): copyTagsToSnapshot is missing in the DatabaseCluster Construct
4 participants