Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(region-info): add missing dlc repository accounts. #30147

Merged
merged 4 commits into from
May 13, 2024

Conversation

SankyRed
Copy link
Contributor

@SankyRed SankyRed commented May 10, 2024

Issue # (if applicable)

Add missing DLC repository account information for multiple regions.

Reason for this change

As part of exteding support to new regions we require the DLC_REPOSITORY_ACCOUNTS for those specific regions in our fact-tables.

Description of changes

Added missing information for few regions we already provide support to. Also, updated the reference doc links since they are out of date and haven't been updated in a long time and we need to reference the new docs to fetch the required information.

Description of how you validated changes

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@SankyRed SankyRed added the pr/do-not-merge This PR should not be merged at this time. label May 10, 2024
@github-actions github-actions bot added the p2 label May 10, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team May 10, 2024 19:16
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label May 10, 2024
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label May 10, 2024
bergjaak
bergjaak previously approved these changes May 13, 2024
@bergjaak bergjaak dismissed their stale review May 13, 2024 14:45

realized I need more clarification

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label May 13, 2024
@SankyRed SankyRed removed the pr/do-not-merge This PR should not be merged at this time. label May 13, 2024
Copy link
Contributor

mergify bot commented May 13, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: fce0e9c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 7ed3460 into main May 13, 2024
12 checks passed
@mergify mergify bot deleted the SankyRed/dlc-accounts branch May 13, 2024 17:20
Copy link
Contributor

mergify bot commented May 13, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants