Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(docdb): i/o optimized storage type #30163

Merged
merged 22 commits into from
Sep 4, 2024
Merged

feat(docdb): i/o optimized storage type #30163

merged 22 commits into from
Sep 4, 2024

Conversation

badmintoncryer
Copy link
Contributor

@badmintoncryer badmintoncryer commented May 12, 2024 •
edited
Loading

Issue # (if applicable)

Closes #30165.

Reason for this change

Document DB can use I/O optimized storage type but CDK cannot configure that.

Description of changes

Add storageType to ClusterProps.

Description of how you validated changes

Add both unit and integ tests.

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team May 12, 2024 15:23
@github-actions github-actions bot added star-contributor [Pilot] contributed between 25-49 PRs to the CDK p2 labels May 12, 2024
aws-cdk-automation
aws-cdk-automation previously requested changes May 12, 2024
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@badmintoncryer badmintoncryer changed the title feat(docdb): I/O optimized storage type feat(docdb): i/o optimized storage type May 12, 2024
@badmintoncryer badmintoncryer marked this pull request as ready for review May 12, 2024 15:36
@aws-cdk-automation aws-cdk-automation dismissed their stale review May 12, 2024 15:38

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@github-actions github-actions bot added the feature-request A feature should be added or improved. label May 12, 2024
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label May 12, 2024
@github-actions github-actions bot mentioned this pull request May 13, 2024
Closed
@aws-cdk-automation
Copy link
Collaborator

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

@github-actions github-actions bot mentioned this pull request Jun 1, 2024
Closed
comcalvi
comcalvi previously requested changes Jun 20, 2024
View reviewed changes
packages/aws-cdk-lib/aws-docdb/lib/cluster.ts Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-docdb/lib/cluster.ts Show resolved Hide resolved
packages/aws-cdk-lib/aws-docdb/lib/cluster.ts Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-docdb/lib/cluster.ts Show resolved Hide resolved
packages/aws-cdk-lib/aws-docdb/lib/cluster.ts Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-docdb/test/cluster.test.ts Outdated Show resolved Hide resolved
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 20, 2024
badmintoncryer and others added 2 commits June 22, 2024 17:36
@badmintoncryer @comcalvi
Update packages/aws-cdk-lib/aws-docdb/lib/cluster.ts
d3a5b48 
Co-authored-by: Calvin Combs <66279577+comcalvi@users.noreply.github.com>
@badmintoncryer @comcalvi
Update packages/aws-cdk-lib/aws-docdb/lib/cluster.ts
286015c 
Co-authored-by: Calvin Combs <66279577+comcalvi@users.noreply.github.com>
@mergify mergify bot dismissed comcalvi’s stale review June 22, 2024 08:36

Pull request has been modified.

badmintoncryer and others added 4 commits June 22, 2024 17:36
@badmintoncryer @comcalvi
Update packages/aws-cdk-lib/aws-docdb/lib/cluster.ts
87a5ce1 
Co-authored-by: Calvin Combs <66279577+comcalvi@users.noreply.github.com>
@badmintoncryer @comcalvi
Update packages/aws-cdk-lib/aws-docdb/test/cluster.test.ts
5b5d246 
Co-authored-by: Calvin Combs <66279577+comcalvi@users.noreply.github.com>
@badmintoncryer
update
f8db633
@badmintoncryer
Merge branch 'main' into storageTypeForDocDb
21ac3b0
@badmintoncryer
Copy link
Contributor Author

@comcalvi Thank you for your review! I've addressed your comments.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 23, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 4, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Sep 4, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 4, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 351d643
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 7ed221c into aws:main Sep 4, 2024
9 checks passed
@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 4, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 4, 2024
@badmintoncryer badmintoncryer deleted the storageTypeForDocDb branch September 4, 2024 23:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kaizencc kaizencc kaizencc approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

@comcalvi comcalvi comcalvi left review comments

Assignees
No one assigned
Labels
feature-request A feature should be added or improved. p2 star-contributor [Pilot] contributed between 25-49 PRs to the CDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docdb: support for specifying storage type for Cluster
4 participants
@badmintoncryer @aws-cdk-automation @kaizencc @comcalvi