Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(rds): add aurora postgresql versions 12.18, 13.14 and 14.11 #30168

Merged
merged 3 commits into from
May 16, 2024
Merged

chore(rds): add aurora postgresql versions 12.18, 13.14 and 14.11 #30168

merged 3 commits into from
May 16, 2024

Conversation

mazyu36
Copy link
Contributor

@mazyu36 mazyu36 commented May 13, 2024 •
edited
Loading

@github-actions github-actions bot added the p2 label May 13, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team May 13, 2024 00:08
@github-actions github-actions bot added the repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK label May 13, 2024
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label May 13, 2024
@go-to-k
Copy link
Contributor

go-to-k commented May 15, 2024

Could you please change the PR title to chore(rds): add aurora postgresql versions 12.18, 13.14 and 14.11? There are only three, so it would be fine to write them down and they would be easy to understand.

@mazyu36 mazyu36 changed the title chore(rds): add three aurora postgresql version chore(rds): add aurora postgresql versions 12.18, 13.14 and 14.11 May 15, 2024
@mazyu36
Copy link
Contributor Author

mazyu36 commented May 15, 2024

@go-to-k
Thank you for your review.
I changed the title.

go-to-k
go-to-k approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@go-to-k go-to-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels May 15, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented May 16, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label May 16, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 9e84793
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 2f7030a into aws:main May 16, 2024
12 checks passed
@mergify Mergify
Copy link
Contributor

mergify bot commented May 16, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mazyu36 mazyu36 deleted the aurora-version-add branch May 17, 2024 04:19
@github-actions github-actions bot mentioned this pull request May 20, 2024
Closed
@github-actions github-actions bot mentioned this pull request Jun 1, 2024
Closed
atanaspam pushed a commit to atanaspam/aws-cdk that referenced this pull request Jun 3, 2024
@mazyu36 @atanaspam
chore(rds): add aurora postgresql versions 12.18, 13.14 and 14.11 (aw…
5463b3f 
…s#30168)

### Description of changes
Add three AuroraPostgreSQL version.

https://docs.aws.amazon.com/AmazonRDS/latest/AuroraPostgreSQLReleaseNotes/AuroraPostgreSQL.Updates.html#AuroraPostgreSQL.Updates.20180305.1218X

https://docs.aws.amazon.com/AmazonRDS/latest/AuroraPostgreSQLReleaseNotes/AuroraPostgreSQL.Updates.html#AuroraPostgreSQL.Updates.20180305.1314

https://docs.aws.amazon.com/AmazonRDS/latest/AuroraPostgreSQLReleaseNotes/AuroraPostgreSQL.Updates.html#AuroraPostgreSQL.Updates.20180305.14110



### Description of how you validated changes



### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@aws-cdk-automation
Copy link
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@GavinZZ GavinZZ GavinZZ approved these changes

@go-to-k go-to-k go-to-k approved these changes

@Chemsmith Chemsmith Chemsmith approved these changes

Assignees
No one assigned
Labels
p2 repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mazyu36 @go-to-k @aws-cdk-automation @Chemsmith @GavinZZ