-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(events): detailType doesnt allow filtering patterns #30222
Conversation
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Failing excerpt
Based on this I've created some additional tests in the highlighted area above, namely around the use of ICustomEventRule inside of aws-codepipeline-actions. Additionally i've updated the integration tests for The additional steps i've taken are documented below:
There doesn't appear to be any regressions from this change in aws-codepipeline-actions based on the available unit or integration tests. Though we still fail during the CodeBuild run, specifically during
Admittedly I am at a bit of a loss as to best way to proceed, I don't seem to be able to find this limitation in the CloudFormation or CodeCommit documentation [0][1]. Any help is appreciated, thanks! [0] https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-events-rule.html#cfn-events-rule-eventpattern |
This PR has been in the BUILD FAILING state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
Issue # (if applicable)
Closes #30220
Reason for this change
Unable to use content based filtering patterns based on an events detailType using the
events.Rule
L2 construct without leveraging a trap doorDescription of changes
Allow for the usage of content based filtering patterns based on an events detailType
Description of how you validated changes
Overall these are the steps that i've taken:
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license