-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ec2): add v7 VPC flow log record fields #30229
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
Exemption Request
|
The pull request linter fails with the following errors:
PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing ✅ A exemption request has been requested. Please wait for a maintainer's review. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
@gricey432 This PR(#30202) has already been submitted. |
Awesome! Looks like it's in much better shape than mine, closing in favour |
Thanks! We look forward to another PR! |
@badmintoncryer what's happening with the process here? That other PR has been waiting on a review for over a month. Is there anything I can be doing to assist with the process of getting this change in in some form? |
@gricey432 It seems to be waiting for community review. This process may take several months, because it is unclear when the reviewers will look at it😓 So please be patient. |
Reason for this change
AWS recently added new ECS-focused fields to the VPC flow logs.
Description of changes
Update CDK's list of fields to include the new fields.
I've just followed the pattern that was there.
Description of how you validated changes
Extended the existing tests. Though I'm unable to run the integration tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license