Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(s3-deployment): update development section of readme #30253

Merged
merged 5 commits into from
May 31, 2024
Merged

docs(s3-deployment): update development section of readme #30253

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cbfad03
docs(s3-deployment): update development section of the aws-s3-deploym…
neo01124 May 17, 2024
b973b09
Update packages/aws-cdk-lib/aws-s3-deployment/README.md
scanlonp May 30, 2024
69b5a19
Update packages/aws-cdk-lib/aws-s3-deployment/README.md
scanlonp May 30, 2024
e7e98a1
Merge branch 'main' into s3-doc-update
scanlonp May 30, 2024
6e83116
Merge branch 'main' into s3-doc-update
mergify[bot] May 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/aws-cdk-lib/aws-s3-deployment/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -489,8 +489,9 @@ new cdk.CfnOutput(this, 'ObjectKey', {
## Development

The custom resource is implemented in Python 3.9 in order to be able to leverage
the AWS CLI for "aws s3 sync". The code is under [`lib/lambda`](https://github.com/aws/aws-cdk/tree/main/packages/aws-cdk-lib/aws-s3-deployment/lib/lambda) and
unit tests are under [`test/lambda`](https://github.com/aws/aws-cdk/tree/main/packages/aws-cdk-lib/aws-s3-deployment/test/lambda).
the AWS CLI for "aws s3 sync".
The code is now in the `@aws-cdk/custom-resource-handlers` package under [`lib/aws-s3-deployment/bucket-deployment-handler`](https://github.com/aws/aws-cdk/tree/main/packages/@aws-cdk/custom-resource-handlers/lib/aws-s3-deployment/bucket-deployment-handler/) and
unit tests are under [`test/aws-s3-deployment/bucket-deployment-handler`](https://github.com/aws/aws-cdk/tree/main/packages/@aws-cdk/custom-resource-handlers/test/aws-s3-deployment/bucket-deployment-handler/).

This package requires Python 3.9 during build time in order to create the custom
resource Lambda bundle and test it. It also relies on a few bash scripts, so
Expand Down