-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(cdk): update the fact tables and tests for lambda layers v0.98.0 #30263
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
| [@aws-cdk/aws-ec2:ebsDefaultGp3Volume](#aws-cdkaws-ec2ebsdefaultgp3volume) | When enabled, the default volume type of the EBS volume will be GP3 | 2.140.0 | (default) | | ||
| [@aws-cdk/pipelines:reduceAssetRoleTrustScope](#aws-cdkpipelinesreduceassetroletrustscope) | Remove the root account principal from PipelineAssetsFileRole trust policy | 2.141.0 | (default) | | ||
| [@aws-cdk/aws-ecs:removeDefaultDeploymentAlarm](#aws-cdkaws-ecsremovedefaultdeploymentalarm) | When enabled, remove default deployment alarm settings | V2NEXT | (default) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are these changes and why are they here in this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems this change might be added by default when huy had built the package in local at the time of PR. By updating the branch of the PR it should fix i guess. unfortunately i dont' have permissions to do that, since i didn't create it. hey Gavin, is it possible for you update the branch or do you recommend me creating a new PR with these changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mergify update |
❌ Mergify doesn't have permission to updateFor security reasons, Mergify can't update this pull request. Try updating locally. |
Do you think it has to be done manually :( |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
@mergify update |
❌ Command disallowed due to command restrictions in the Mergify configuration.
|
#30448) Update ADOT Lambda Layer ARNs for recent release aws-observability/aws-otel-lambda#922 includes the PR changes - #30263 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
aws#30448) Update ADOT Lambda Layer ARNs for recent release aws-observability/aws-otel-lambda#922 includes the PR changes - aws#30263 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
aws#30448) Update ADOT Lambda Layer ARNs for recent release aws-observability/aws-otel-lambda#922 includes the PR changes - aws#30263 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Update ADOT Lambda Layer ARNs for recent release
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license