fix(opensearchservice): openSearchLogGroupResourcePolicy unnecessarily attempts to install latest sdk version #30322
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #23113
Closes #23113 (Already closed, but looks like some changes were missed)
Related: #28688
Please let me know if the title needs to be changed. The title for the related pull request was approved, but the linter here indicates otherwise.
Reason for this change
If the flag is set to true, the custom resource has nondeterministic behavior, such as longer execution time and network access.
Description of changes
Explicitly set installLatestAwsSdk to false for OpenSearch and ElasticSearch's LogGroupResourcePolicies. No need to set it for AWS EventTargets's LogGroupResourcePolicy because they have a prop that allows the consumer to override it.
Description of how you validated changes
(Copied from #28688)
No tests add because the existing tests run with the @aws-cdk/customresources:installLatestAwsSdkDefault feature flag set to the recommended value. This change is merely change the OpenSearchAccessPolicy config for users that don't set the feature flag. We can safely do this, because we control the code for this custom resource and know it works with the provided SDK version.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license