Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ec2): security group lookup by name, vpc, and owner #30334

Closed
wants to merge 17 commits into from

Conversation

eschirle
Copy link

Issue

Closes #30331

Reason for this change

To allow fromLookupByName to filter security groups by owner.

Description of changes

Adds an optional input to fromLookupByName and updates the security group context provider to support a filter on owner.

Description of how you validated changes

Unit tests updated for ec2.security-group and context-providers.security-groups

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team May 24, 2024 21:45
@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK feature-request A feature should be added or improved. p2 labels May 24, 2024
@eschirle eschirle changed the title feat: ec2 security group lookup by name, vpc, and owner feat(ec2): security group lookup by name, vpc, and owner May 24, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@eschirle eschirle marked this pull request as ready for review May 30, 2024 23:08
@eschirle
Copy link
Author

Clarification Request

Looking for some clarity on what else is needed for this - unit tests, integration tests, and codebuild test all seem to be passing.
I don't see any integration tests for securitygroups under packages/@aws-cdk-testing/test/aws-ec2, so I haven't made any changes to the integration tests.

@aws-cdk-automation
Copy link
Collaborator

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@aws-cdk-automation aws-cdk-automation added the pr/needs-cli-test-run This PR needs CLI tests run against it. label Jun 17, 2024
@eschirle
Copy link
Author

eschirle commented Jun 19, 2024

Clarification Request

Can someone take a look at this pipeline request? this has been stuck in a waiting state for 3+ weeks
image

@aws-cdk-automation aws-cdk-automation added the pr/reviewer-clarification-requested The contributor has requested clarification on feedback, a failing build, or a failing PR Linter run label Jun 19, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 9910d38
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 19, 2024
@aws-cdk-automation
Copy link
Collaborator

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

@aws-cdk-automation aws-cdk-automation added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label Jun 23, 2024
@QuantumNeuralCoder
Copy link

@eschirle
Sharing a resource on PRs. 27:14 covers integ testing.

@github-actions github-actions bot added the effort/small Small work item – less than a day of effort label Jul 2, 2024
@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ Features must contain a change to an integration test file and the resulting snapshot.
❌ CLI code has changed. A maintainer must run the code through the testing pipeline (git fetch origin pull/30334/head && git push -f origin FETCH_HEAD:test-main-pipeline), then add the 'pr-linter/cli-integ-tested' label when the pipeline succeeds.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

@paulhcsun
Copy link
Contributor

Hi @eschirle, thank you for your contribution and the effort you've put into this PR. After reviewing, I noticed that a second PR (#30625) was opened after yours which provides a similar solution but allows filtering on additional properties which will be a better long term solution for looking up security groups. Therefore I will be closing this PR and proceed with the other. We appreciate your understanding.

@paulhcsun paulhcsun closed this Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 pr/needs-cli-test-run This PR needs CLI tests run against it. pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. pr/reviewer-clarification-requested The contributor has requested clarification on feedback, a failing build, or a failing PR Linter run
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EC2: Security Groups lookup by Owner
4 participants