fix(globalaccelerator-endpoints): add preserveClientIp option for net… #30346

SaschaJanssen · 2024-05-27T08:32:20Z

…work loadbalancer

Issue # (if applicable)

Reason for this change

preserveClientIp was missing for GlobalAccelerator Endpoints when using a network loadbalancer.

Description of changes

add missing network load balancer endpoint prop.

Description of how you validated changes

Added unit tests.

Checklist

My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

aws-cdk-automation

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

…work loadbalancer ### Issue # (if applicable) ### Reason for this change preserveClientIp was missing for GlobalAccelerator Endpoints when using a network loadbalancer. ### Description of changes * add missing network load balancer endpoint prop. ### Description of how you validated changes Added integration tests. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

scorbiere

Thank you for your contribution. Would you mind updating the default value in the comment? Then I can approve the PR.

scorbiere · 2024-06-12T20:24:10Z

packages/aws-cdk-lib/aws-globalaccelerator-endpoints/lib/nlb.ts

+   * Client IP address preservation is supported only in specific AWS Regions.
+   * See the GlobalAccelerator Developer Guide for a list.
+   *
+   * @default true if available


According to the documentation, my understanding is that the default value is false :
https://docs.aws.amazon.com/global-accelerator/latest/dg/preserve-client-ip-address.html

When you add an Network Load Balancer with security groups as an endpoint in Global Accelerator, client IP address preservation is not enabled by default.

Suggested change

* @default true if available

* @default false

…work loadbalancer preserveClientIp was missing for GlobalAccelerator Endpoints when using a network loadbalancer. * add missing network load balancer endpoint prop. Added integration tests. - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

Pull request has been modified.

SaschaJanssen · 2024-06-14T11:28:25Z

@scorbiere thanks, updated the doc.

scorbiere

LGTM, thanks for the update.

mergify · 2024-06-17T17:21:37Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify · 2024-06-17T19:28:29Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

scorbiere · 2024-06-18T17:57:51Z

@mergify update

mergify · 2024-06-18T17:58:32Z

update

❌ Mergify doesn't have permission to update

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/github-merit-badger.yml without workflows permission

Pull request has been modified.

scorbiere

Re-approving after updating the branch.

mergify · 2024-06-18T21:08:00Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

aws-cdk-automation · 2024-06-18T22:11:08Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: f647afb
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2024-06-18T22:11:32Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

aws#30346) …work loadbalancer ### Issue # (if applicable) ### Reason for this change preserveClientIp was missing for GlobalAccelerator Endpoints when using a network loadbalancer. ### Description of changes * add missing network load balancer endpoint prop. ### Description of how you validated changes Added unit tests. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

aws-cdk-automation · 2024-07-25T20:51:10Z

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

aws-cdk-automation requested a review from a team May 27, 2024 08:32

github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 labels May 27, 2024

aws-cdk-automation previously requested changes May 27, 2024

View reviewed changes

This was referenced Jun 1, 2024

Monthly PR metrics report #30414

Closed

Weekly PR metrics report #30434

Closed

SaschaJanssen force-pushed the feat-aga-endpoint-preserveclientip branch from be3c0fd to e85316e Compare June 12, 2024 11:31

aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 12, 2024

SaschaJanssen force-pushed the feat-aga-endpoint-preserveclientip branch from e85316e to a88c711 Compare June 12, 2024 13:28

scorbiere previously requested changes Jun 12, 2024

View reviewed changes

aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 12, 2024

aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 14, 2024

scorbiere previously approved these changes Jun 17, 2024

View reviewed changes

aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 17, 2024

Merge branch 'main' into feat-aga-endpoint-preserveclientip

3e240a4

aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 18, 2024

scorbiere approved these changes Jun 18, 2024

View reviewed changes

Merge branch 'main' into feat-aga-endpoint-preserveclientip

f647afb

mergify bot merged commit c1e1b4d into aws:main Jun 18, 2024
9 checks passed

This was referenced Jul 12, 2024

[Snyk] Upgrade: , aws-cdk NOUIY/aws-solutions-constructs#108

Open

[Snyk] Upgrade: , aws-cdk NOUIY/aws-solutions-constructs#109

Open

This was referenced Jul 19, 2024

[Snyk] Upgrade: , aws-cdk NOUIY/aws-solutions-constructs#110

Open

[Snyk] Upgrade: , aws-cdk NOUIY/aws-solutions-constructs#111

Open

aws locked as resolved and limited conversation to collaborators Jul 25, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(globalaccelerator-endpoints): add preserveClientIp option for net… #30346

fix(globalaccelerator-endpoints): add preserveClientIp option for net… #30346

SaschaJanssen commented May 27, 2024 •

edited

Loading

aws-cdk-automation left a comment

scorbiere left a comment

scorbiere Jun 12, 2024

SaschaJanssen commented Jun 14, 2024

scorbiere left a comment

mergify bot commented Jun 17, 2024

mergify bot commented Jun 17, 2024

scorbiere commented Jun 18, 2024

mergify bot commented Jun 18, 2024

scorbiere left a comment

mergify bot commented Jun 18, 2024

aws-cdk-automation commented Jun 18, 2024

mergify bot commented Jun 18, 2024

aws-cdk-automation commented Jul 25, 2024

fix(globalaccelerator-endpoints): add preserveClientIp option for net… #30346

fix(globalaccelerator-endpoints): add preserveClientIp option for net… #30346

Conversation

SaschaJanssen commented May 27, 2024 • edited Loading

Issue # (if applicable)

Reason for this change

Description of changes

Description of how you validated changes

Checklist

aws-cdk-automation left a comment

Choose a reason for hiding this comment

scorbiere left a comment

Choose a reason for hiding this comment

scorbiere Jun 12, 2024

Choose a reason for hiding this comment

SaschaJanssen commented Jun 14, 2024

scorbiere left a comment

Choose a reason for hiding this comment

mergify bot commented Jun 17, 2024

mergify bot commented Jun 17, 2024

scorbiere commented Jun 18, 2024

mergify bot commented Jun 18, 2024

❌ Mergify doesn't have permission to update

scorbiere left a comment

Choose a reason for hiding this comment

mergify bot commented Jun 18, 2024

aws-cdk-automation commented Jun 18, 2024

AWS CodeBuild CI Report

mergify bot commented Jun 18, 2024

aws-cdk-automation commented Jul 25, 2024

SaschaJanssen commented May 27, 2024 •

edited

Loading