Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cloudfront): managed cache policies UseOriginCacheControlHeaders #30379

Conversation

chrishanline
Copy link

@chrishanline chrishanline commented May 30, 2024

Reason for this change

Cloudfront provides two additional managed cache policies, UseOriginCacheControlHeaders and UseOriginCacheControlHeaders-QueryStrings that are not currently present as constants in the CDK. Five of the managed policies are currently provided as constants in the CDK.

Description of changes

This PR adds two new constants, USE_ORIGIN_CACHE_CONTROL_HEADERS and USE_ORIGIN_CACHE_CONTROL_HEADERS_QUERY_STRINGS, in the style of the other existing constants for managed cache policies.

Each are mapped to the policy ID provided by AWS:
USE_ORIGIN_CACHE_CONTROL_HEADERS: 83da9c7e-98b4-4e11-a168-04f0df8e2c65
USE_ORIGIN_CACHE_CONTROL_HEADERS_QUERY_STRINGS: 4cc15a8a-d715-48a4-82b8-cc0b614638fe

Tests are included for the two new constants, as well as covering a missing test for the AMPLIFY policy.

Description of how you validated changes

The existing unit test was expanded to included the two new, plus one previously missing, constants.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label May 30, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team May 30, 2024 02:17
@github-actions github-actions bot added the p2 label May 30, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@chrishanline chrishanline changed the title feat(cloudfront): UseOriginCacheControlHeaders managed cache policies feat(cloudfront): managed cache policies UseOriginCacheControlHeaders May 30, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 8aa4e82
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@chrishanline
Copy link
Author

Exemption Request - I don’t believe a README change or integration test is needed for this change

@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ Features must contain a change to a README file.
❌ Features must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

✅ A exemption request has been requested. Please wait for a maintainer's review.

This was referenced Jun 1, 2024
@aws-cdk-automation
Copy link
Collaborator

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@aws-cdk-automation
Copy link
Collaborator

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

@aws-cdk-automation aws-cdk-automation added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label Jun 29, 2024
@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ Features must contain a change to a README file.
❌ Features must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

✅ A exemption request has been requested. Please wait for a maintainer's review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants