Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(codebuild): allow specifying principals and credentials for pulling build images #3049

Merged
merged 1 commit into from
Jul 7, 2019

Commits on Jul 7, 2019

  1. feat(codebuild): allow specifying principals and credentials for pull…

    …ing build images.
    
    When using an image that is hosted in a private Docker registry,
    you have to pass the appropriate credentials in order to authenticate against that registry.
    This change allows passing those credentials when creating a custom build image.
    
    It also introduces the concept of the principal that CodeBuild will use to pull the image -
    previously, CodeBuild would always use its own identity when pulling images,
    which meant using it with an ECR-hosted image required changing the resource policy of the repository to trust CodeBuild's service principal.
    Now, the default is to use the project's role when doing the pull of the image.
    
    Fixes aws#2175
    
    BREAKING CHANGE: codebuild.LinuxBuildImage.fromDockerHub() has been renamed to fromDockerRegistry()
    * codebuild.WindowsBuildImage.fromDockerHub() has been renamed to fromDockerRegistry()
    Kaixiang-AWS authored and skinny85 committed Jul 7, 2019
    Configuration menu
    Copy the full SHA
    e218f9d View commit details
    Browse the repository at this point in the history