feat(codepipeline): add Triggers and Trigger Filters for CodeStarSourceConnection action #30516
Conversation
This change deprecates the old filters and re-scopes adding them to the only action where they are valid. This also adds classes for simplifying the input of filters for all filter types
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
| test('onTags returns no filters when none are provided', () => { | ||
| expect(() => | ||
| Filter.push(PushFilter.onTags({})), | ||
| ).toThrow('PushFilter.onTags() must contain at least one \'includes\' or \'excludes\' pattern.'); | ||
| }); |
There was a problem hiding this comment.
| test('onTags returns no filters when none are provided', () => { | |
| expect(() => | |
| Filter.push(PushFilter.onTags({})), | |
| ).toThrow('PushFilter.onTags() must contain at least one \'includes\' or \'excludes\' pattern.'); | |
| }); | |
| test('onTags throws when no filters are provided', () => { | |
| expect(() => | |
| Filter.push(PushFilter.onTags({})), | |
| ).toThrow('PushFilter.onTags() must contain at least one \'includes\' or \'excludes\' pattern.'); | |
| }); |
| const filter = Filter.push(PushFilter.onTags({ | ||
| includes: ['tag1', 'tag2'], | ||
| })); | ||
|
|
||
| expect(filter._push?.tags).toEqual({ includes: ['tag1', 'tag2'] }); | ||
| expect(filter._push?.branches).toBeUndefined(); | ||
| expect(filter._push?.filePaths).toBeUndefined(); | ||
| expect(filter._pullRequest).toBeUndefined(); |
There was a problem hiding this comment.
This looks like testing implementation details, but I appreciate the brevity of these tests. We should have a unit test that shows using a Filter with a Trigger on an Action, so we get some tests that cover (and show) the intended usage.
|
The pull request linter fails with the following errors: PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing |
|
@TheRealAmazonKendra any progress on this? It appears to have been sitting idle for a month and a half |
|
Any plan to merge the code ? |
|
Really want to see this PR land. This is a long-awaited feature. |
|
Woow, it's been "dead" for 3 months, for a feature that is long awaited... Maybe some help is needed? |
Its really disappointing because it was fixed by a contributor, and then AWS said they didn't like how it was done, backed it out, created this and let it hang out here for months. If AWS wants to do it themselves, maybe we need a project owner's eyes to get it re-prioritized and assigned to someone who will finish it |
|
Any clue when this PR will be merged? |
|
one up vote for this feature please! |
|
Any news on when this fix will be released? |
I have seen no evidence this stayed on the radar of anyone at AWS after they overruled the initial implementation someone submitted. Does anyone know who we can tag so someone from the team will actually start paying attention? |
This change deprecates the old Triggers and re-scopes adding them to the only action where they are valid.
This also adds classes for simplifying the input of filters for all filter types
Issue # (if applicable)
Closes #.
Still TODO:
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license