feat(location): support Map #30648

mazyu36 · 2024-06-24T16:39:42Z

Issue # (if applicable)

Closes #30647.

Reason for this change

In aws-location-alpha, map has not been supported yet.

Description of changes

Add Map class.

Description of how you validated changes

Add a unit test and a integ test.

Checklist

My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

mazyu36 · 2024-06-24T16:42:51Z

packages/@aws-cdk/aws-location-alpha/lib/map.ts

+export enum CustomLayer {
+  /**
+   * The POI custom layer adds a richer set of places, such as shops, services, restaurants, attractions, and other points of interest to your map.
+   * Currently only the VectorEsriNavigation map style supports the POI custom layer.


I considered adding this validation, but decided against it as I thought the scope might expand in the future, potentially making it unnecessary. Please provide any opinions if you have them.

mazyu36 · 2024-06-24T16:45:55Z

packages/@aws-cdk/aws-location-alpha/lib/map.ts

+  /**
+   * An India (IND) political view
+   */
+  INDIA = 'IND',


According to docs, political view can only be used with specific styles. However, considering the possibility that future AWS updates might expand its applicability, I have decided not to add validation at this time.

Please provide any feedback if you have any.

…x class (#30974) ### Issue # (if applicable) N/A ### Reason for this change Add validation for PlaceIndex description, similar to #30648, #30682, and #30711 . ### Description of changes Add validation and unit tests for description. ### Description of how you validated changes Add unit tests. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

badmintoncryer

I've added some minor comments.

packages/@aws-cdk/aws-location-alpha/lib/map.ts

badmintoncryer · 2024-11-04T07:17:41Z

packages/@aws-cdk/aws-location-alpha/test/map.test.ts

+  })).toThrow('`description` must be between 0 and 1000 characters. Received: 1001 characters');
+});
+
+test('throws with invalid name', () => {


How about adding the test about invalid name length?

Thanks. I've added a test.
Also I've refactored the code to separate the regex pattern check and length check, as I think it would be more user-friendly.

mazyu36 · 2024-11-04T14:35:24Z

@badmintoncryer
Thank you for the review!
I’ve updated.

badmintoncryer

Please delete only the tests that were likely left behind by mistake!

packages/@aws-cdk/aws-location-alpha/test/map.test.ts

packages/@aws-cdk/aws-location-alpha/lib/map.ts

GavinZZ

Really high quality PR, appreciate it!

codecov · 2024-11-20T23:00:44Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.17%. Comparing base (e3024fc) to head (0ce3049).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #30648   +/-   ##
=======================================
  Coverage   77.17%   77.17%           
=======================================
  Files         105      105           
  Lines        7169     7169           
  Branches     1315     1315           
=======================================
  Hits         5533     5533           
  Misses       1455     1455           
  Partials      181      181

Flag	Coverage Δ
suite.unit	`77.17% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
packages/aws-cdk	`77.17% <ø> (ø)`

---- 🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests
JS Bundle Analysis - Avoid shipping oversized bundles

mergify · 2024-11-20T23:20:07Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mazyu36 · 2024-11-20T23:48:01Z

@Mergifyio update

mergify · 2024-11-20T23:48:09Z

update

✅ Branch has been successfully updated

mergify · 2024-11-21T00:20:07Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

aws-cdk-automation · 2024-11-21T01:17:36Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: 0ce3049
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2024-11-21T01:17:45Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

github-actions · 2024-11-21T01:18:01Z

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

aws-cdk-automation requested a review from a team June 24, 2024 16:39

github-actions bot added star-contributor [Pilot] contributed between 25-49 PRs to the CDK feature-request A feature should be added or improved. p2 labels Jun 24, 2024

mazyu36 commented Jun 24, 2024

View reviewed changes

mazyu36 marked this pull request as ready for review June 24, 2024 17:05

feat: support Map

9d9b731

mazyu36 force-pushed the location-service-map branch from 6945287 to 9d9b731 Compare June 24, 2024 17:08

Merge branch 'main' into location-service-map

cf12522

khushail added the effort/small Small work item – less than a day of effort label Jun 24, 2024

mazyu36 added 3 commits June 25, 2024 09:21

update docs

f842ce7

Merge branch 'main' into location-service-map

af5ed10

fix: update README

679cbd1

aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 25, 2024

mazyu36 added 2 commits June 27, 2024 00:57

minor update

270aeb8

Merge branch 'main' into location-service-map

80ca57d

This was referenced Jul 1, 2024

Monthly PR metrics report #30715

Closed

Weekly PR metrics report #30720

Closed

mazyu36 added 4 commits July 28, 2024 18:04

Merge branch 'main' into location-service-map

650abf1

fix typo

669ee9e

add description validation

d7509a9

update validation

91e92e2

mazyu36 force-pushed the location-service-map branch from c65cae2 to 91e92e2 Compare July 29, 2024 14:55

mazyu36 mentioned this pull request Jul 29, 2024

chore(location): add validation for description property in PlaceIndex class #30974

Merged

1 task

mazyu36 added 4 commits August 1, 2024 07:25

update docs

bdea4a4

Merge branch 'main' into location-service-map

2a457dc

Merge branch 'main' into location-service-map

c002d62

update

3397333

mazyu36 added 2 commits October 8, 2024 09:26

Merge branch 'main' into location-service-map

0f33f2c

Merge branch 'main' into location-service-map

2078853

badmintoncryer suggested changes Nov 4, 2024

View reviewed changes

fix

8641f54

aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 4, 2024

mazyu36 requested a review from badmintoncryer November 4, 2024 14:35

badmintoncryer approved these changes Nov 5, 2024

View reviewed changes

packages/@aws-cdk/aws-location-alpha/test/map.test.ts Outdated Show resolved Hide resolved

packages/@aws-cdk/aws-location-alpha/test/map.test.ts Outdated Show resolved Hide resolved

delete unnecessary tests

53acba4

aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 5, 2024

Merge branch 'main' into location-service-map

11a04f1

paulhcsun self-assigned this Nov 6, 2024

Merge branch 'main' into location-service-map

5f5d6b8

paulhcsun removed their assignment Nov 19, 2024

GavinZZ reviewed Nov 20, 2024

View reviewed changes

packages/@aws-cdk/aws-location-alpha/lib/map.ts Outdated Show resolved Hide resolved

Update packages/@aws-cdk/aws-location-alpha/lib/map.ts

472fb6f

GavinZZ approved these changes Nov 20, 2024

View reviewed changes

aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 20, 2024

Merge branch 'main' into location-service-map

01b3e35

Merge branch 'main' into location-service-map

0ce3049

mergify bot merged commit 98b801c into aws:main Nov 21, 2024
17 checks passed

github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(location): support Map #30648

feat(location): support Map #30648

mazyu36 commented Jun 24, 2024

mazyu36 Jun 24, 2024

mazyu36 Jun 24, 2024

badmintoncryer left a comment

badmintoncryer Nov 4, 2024

mazyu36 Nov 4, 2024

mazyu36 commented Nov 4, 2024

badmintoncryer left a comment

GavinZZ left a comment

codecov bot commented Nov 20, 2024 •

edited

Loading

mergify bot commented Nov 20, 2024

mazyu36 commented Nov 20, 2024

mergify bot commented Nov 20, 2024

mergify bot commented Nov 21, 2024

aws-cdk-automation commented Nov 21, 2024

mergify bot commented Nov 21, 2024

github-actions bot commented Nov 21, 2024

feat(location): support Map #30648

feat(location): support Map #30648

Conversation

mazyu36 commented Jun 24, 2024

Issue # (if applicable)

Reason for this change

Description of changes

Description of how you validated changes

Checklist

mazyu36 Jun 24, 2024

Choose a reason for hiding this comment

mazyu36 Jun 24, 2024

Choose a reason for hiding this comment

badmintoncryer left a comment

Choose a reason for hiding this comment

badmintoncryer Nov 4, 2024

Choose a reason for hiding this comment

mazyu36 Nov 4, 2024

Choose a reason for hiding this comment

mazyu36 commented Nov 4, 2024

badmintoncryer left a comment

Choose a reason for hiding this comment

GavinZZ left a comment

Choose a reason for hiding this comment

codecov bot commented Nov 20, 2024 • edited Loading

Codecov Report

mergify bot commented Nov 20, 2024

mazyu36 commented Nov 20, 2024

mergify bot commented Nov 20, 2024

✅ Branch has been successfully updated

mergify bot commented Nov 21, 2024

aws-cdk-automation commented Nov 21, 2024

AWS CodeBuild CI Report

mergify bot commented Nov 21, 2024

github-actions bot commented Nov 21, 2024

codecov bot commented Nov 20, 2024 •

edited

Loading