feat(pipes-targets): add CloudWatch Logs #30665

msambol · 2024-06-25T20:47:12Z

Add CloudWatch Logs as a Pipe target.

nmussy

LGTM, just a couple of nitpicks

packages/@aws-cdk/aws-pipes-targets-alpha/README.md

nmussy · 2024-06-26T15:06:37Z

packages/@aws-cdk/aws-pipes-targets-alpha/lib/cloudwatch-logs.ts

+   * @see https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-pipes-pipe-pipetargetcloudwatchlogsparameters.html#cfn-pipes-pipe-pipetargetcloudwatchlogsparameters-timestamp
+   * @default - none
+   */
+  readonly timestamp?: string;


Any reason not to have a number here? You can convert it back to a string in the constructor, and it reduces the chance that a user enters something like a ISO date

I can't get this to work in the Console even:

[ECMA 262 regex "^\$(\.[\w/_-]+(\[(\d+|\*)\])*)*$" does not match input string "1719416220650"]

I'm no regex expert but I can't make sense of that 🤔

@redwheeler3 is there a disconnect between the docs and the API? or am I missing something?

For this one, we expect a JSONPath expression that references the timestamp in your payload. If you try the string "$.data.timestamp" it will validate. Leaving it blank updates it to the current time. We didn't think there was a use case here for specifying an actual time value... you either are going to want the current time or a time extracted from the payload of the event.

@redwheeler3 I updated the above and added an example. I also confirmed $.data.timestamp worked in the Console. We should update the API docs.

aws-cdk-automation · 2024-09-29T00:12:04Z

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

aws-cdk-automation · 2024-10-06T00:11:49Z

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

aws-cdk-automation · 2024-10-07T00:11:30Z

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

msambol · 2024-10-07T22:00:56Z

@Leo10Gama Could we keep rolling on these ? 😄

Leo10Gama

Thanks for another contribution to the pipes targets! Just a few minor requests from my end, but overall looks good

packages/@aws-cdk/aws-pipes-targets-alpha/README.md

packages/@aws-cdk/aws-pipes-targets-alpha/lib/cloudwatch-logs.ts

packages/@aws-cdk/aws-pipes-targets-alpha/test/integ.cloudwatch-logs.ts

Pull request has been modified.

msambol · 2024-10-15T17:52:08Z

@Leo10Gama Fixed! Thanks for the review.

Leo10Gama

Thanks for the changes! I'm still only in disagreement on the current phrasing of the timestamp parameter, since we don't want to give the impression that it supports a value that might be a number. My understanding of how it looks now, we should also aim to describe the value itself, as opposed to exclusively defining it as being referenced by another value, if that makes sense.

packages/@aws-cdk/aws-pipes-targets-alpha/lib/cloudwatch-logs.ts

Leo10Gama

LGTM, thanks again for the contribution!

Leo10Gama · 2024-10-16T18:48:33Z

@Mergifyio update

mergify · 2024-10-16T18:49:07Z

update

✅ Branch has been successfully updated

mergify · 2024-10-16T18:49:09Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

aws-cdk-automation · 2024-10-16T19:19:33Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: a54781a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2024-10-16T19:20:03Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

github-actions · 2024-10-16T19:20:30Z

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

github-actions bot added the p2 label Jun 25, 2024

aws-cdk-automation requested a review from a team June 25, 2024 20:47

github-actions bot added the distinguished-contributor [Pilot] contributed 50+ PRs to the CDK label Jun 25, 2024

msambol marked this pull request as ready for review June 26, 2024 00:27

msambol force-pushed the pipes-targets-cwl branch from a90f01f to a6f3013 Compare June 26, 2024 01:53

aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 26, 2024

nmussy suggested changes Jun 26, 2024

View reviewed changes

aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 26, 2024

msambol force-pushed the pipes-targets-cwl branch from 05c4cfd to 8194e1f Compare June 26, 2024 21:44

This was referenced Jul 1, 2024

Monthly PR metrics report #30715

Closed

Weekly PR metrics report #30720

Closed

msambol force-pushed the pipes-targets-cwl branch from bc1228a to b733d84 Compare September 12, 2024 03:52

msambol force-pushed the pipes-targets-cwl branch from 9731036 to 04369fc Compare September 29, 2024 17:49

msambol force-pushed the pipes-targets-cwl branch from 0aa06cb to b647ed3 Compare October 7, 2024 21:07

msambol force-pushed the pipes-targets-cwl branch from 005a566 to c879abd Compare October 8, 2024 19:48

Leo10Gama self-assigned this Oct 11, 2024

Leo10Gama previously requested changes Oct 15, 2024

View reviewed changes

msambol force-pushed the pipes-targets-cwl branch from c879abd to f785509 Compare October 15, 2024 17:19

msambol force-pushed the pipes-targets-cwl branch from f785509 to f84ce1c Compare October 15, 2024 20:38

Leo10Gama reviewed Oct 16, 2024

View reviewed changes

packages/@aws-cdk/aws-pipes-targets-alpha/lib/cloudwatch-logs.ts Outdated Show resolved Hide resolved

msambol added 4 commits October 16, 2024 10:46

feat(pipes-targets): add CloudWatch Logs

30453a6

Update integration test

48ec0ad

update int test

2e125d9

rename int test

4153ca6

msambol added 17 commits October 16, 2024 10:46

remove files

f0db69c

Update timestamp

3cd5d6d

fix readme

024db4a

Trigger build

0c1b362

Update readme, account for tokens in input validation

427ba92

Fix linting errors

81d9e7e

fix import order

800edac

Update integration test to use SqsSource

bb2376d

Trigger build

e53b135

Fix readme

67a1bc4

Fix numbering

829dda7

remove lint rule

98adc04

Prune readme

6e924c4

Add other feedback Leonardo

a2ea2c1

Capitalization on state machine

117738b

Trigger build

ac05ec8

update doc for timestamp

b7efdbc

msambol force-pushed the pipes-targets-cwl branch from 1980dfa to b7efdbc Compare October 16, 2024 17:48

Leo10Gama approved these changes Oct 16, 2024

View reviewed changes

Merge branch 'main' into pipes-targets-cwl

a54781a

mergify bot merged commit 893769e into aws:main Oct 16, 2024
9 checks passed

github-actions bot locked as resolved and limited conversation to collaborators Oct 16, 2024

msambol deleted the pipes-targets-cwl branch October 16, 2024 19:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(pipes-targets): add CloudWatch Logs #30665

feat(pipes-targets): add CloudWatch Logs #30665

msambol commented Jun 25, 2024 •

edited

Loading

nmussy left a comment

nmussy Jun 26, 2024

msambol Jun 26, 2024

msambol Jun 26, 2024

msambol Jun 26, 2024

redwheeler3 Jun 26, 2024 •

edited

Loading

msambol Jun 26, 2024

aws-cdk-automation commented Sep 29, 2024

aws-cdk-automation commented Oct 6, 2024

aws-cdk-automation commented Oct 7, 2024

msambol commented Oct 7, 2024

Leo10Gama left a comment

msambol commented Oct 15, 2024

Leo10Gama left a comment

Leo10Gama left a comment

Leo10Gama commented Oct 16, 2024

mergify bot commented Oct 16, 2024

mergify bot commented Oct 16, 2024

aws-cdk-automation commented Oct 16, 2024

mergify bot commented Oct 16, 2024

github-actions bot commented Oct 16, 2024

feat(pipes-targets): add CloudWatch Logs #30665

feat(pipes-targets): add CloudWatch Logs #30665

Conversation

msambol commented Jun 25, 2024 • edited Loading

nmussy left a comment

Choose a reason for hiding this comment

nmussy Jun 26, 2024

Choose a reason for hiding this comment

msambol Jun 26, 2024

Choose a reason for hiding this comment

msambol Jun 26, 2024

Choose a reason for hiding this comment

msambol Jun 26, 2024

Choose a reason for hiding this comment

redwheeler3 Jun 26, 2024 • edited Loading

Choose a reason for hiding this comment

msambol Jun 26, 2024

Choose a reason for hiding this comment

aws-cdk-automation commented Sep 29, 2024

aws-cdk-automation commented Oct 6, 2024

aws-cdk-automation commented Oct 7, 2024

msambol commented Oct 7, 2024

Leo10Gama left a comment

Choose a reason for hiding this comment

msambol commented Oct 15, 2024

Leo10Gama left a comment

Choose a reason for hiding this comment

Leo10Gama left a comment

Choose a reason for hiding this comment

Leo10Gama commented Oct 16, 2024

mergify bot commented Oct 16, 2024

✅ Branch has been successfully updated

mergify bot commented Oct 16, 2024

aws-cdk-automation commented Oct 16, 2024

AWS CodeBuild CI Report

mergify bot commented Oct 16, 2024

github-actions bot commented Oct 16, 2024

msambol commented Jun 25, 2024 •

edited

Loading

redwheeler3 Jun 26, 2024 •

edited

Loading