-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(bedrock): add missing models and fix typo #30668
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few more changes to be made, if you want to add them:
+ ai21.j2-ultra-v1:0:8k
+ ai21.jamba-instruct-v1:0
+ amazon.titan-embed-text-v2:0:8k
+ anthropic.claude-3-5-sonnet-20240620-v1:0
+ cohere.command-r-v1:0
+ cohere.embed-english-v3:0:512
+ cohere.embed-multilingual-v3:0:512
+ mistral.mistral-small-2402-v1:0
- anthropic.claude-3-opus-20240229-v1:0
- ccohere.command-r-v1:0
The models listed as "removed" should be deprecated
@nmussy
This has already been added at #30629.
This model is only available in Oregon region. I think this model should not be removed. % aws bedrock get-foundation-model --model-identifier anthropic.claude-3-opus-20240229-v1:0 --region us-west-2
{
"modelDetails": {
"modelArn": "arn:aws:bedrock:us-west-2::foundation-model/anthropic.claude-3-opus-20240229-v1:0",
"modelId": "anthropic.claude-3-opus-20240229-v1:0",
"modelName": "Claude 3 Opus",
"providerName": "Anthropic",
"inputModalities": [
"TEXT",
"IMAGE"
...
I think this is a typo for |
You're absolutely right, I'd forgotten about the region exclusive models. In fact, |
Co-authored-by: Jimmy Gaussen <jimmy.gaussen@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the changes 👍
@Mergifyio update |
✅ Branch has been successfully updated |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
@Mergifyio update |
☑️ Nothing to do
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one. |
Add missing models.
Also, fix typo.
ccohere.command-r-v1:0
->cohere.command-r-v1:0
Ref:
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license