Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pipes-targets): add SageMaker #30696

Merged
merged 10 commits into from
Oct 30, 2024
Merged

feat(pipes-targets): add SageMaker #30696

merged 10 commits into from
Oct 30, 2024

Conversation

msambol
Copy link
Contributor

@msambol msambol commented Jun 27, 2024

Add SageMaker pipeline as a Pipes target.

@aws-cdk-automation aws-cdk-automation requested a review from a team June 27, 2024 17:20
@github-actions github-actions bot added p2 distinguished-contributor [Pilot] contributed 50+ PRs to the CDK labels Jun 27, 2024
@msambol msambol mentioned this pull request Jun 27, 2024
Merged
@aws-cdk-automation aws-cdk-automation added pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Jun 27, 2024
mergify bot pushed a commit that referenced this pull request Jun 28, 2024
@msambol
chore(docs): correct spelling for pipeline (#30697)
afe69b8 
I saw these errors when working on #30696.
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 29, 2024
nmussy
nmussy suggested changes Jun 29, 2024
View reviewed changes
Copy link
Contributor

@nmussy nmussy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall 👍

packages/@aws-cdk/aws-pipes-targets-alpha/lib/sagemaker.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-pipes-targets-alpha/lib/sagemaker.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-pipes-targets-alpha/lib/sagemaker.ts Show resolved Hide resolved
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 29, 2024
This was referenced Jul 1, 2024
Closed
Closed
@msambol msambol force-pushed the pipes-targets-sagemaker branch from 51eda21 to ee3e753 Compare July 1, 2024 15:13
@msambol
Copy link
Contributor Author

msambol commented Jul 1, 2024

@nmussy – updated per your feedback. Thanks as always!

@pahud pahud added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jul 22, 2024
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jul 22, 2024
@aws-cdk-automation
Copy link
Collaborator

This PR has been in the MERGE CONFLICTS state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@msambol msambol force-pushed the pipes-targets-sagemaker branch from 16dce83 to 73f7e71 Compare September 29, 2024 19:30
@aws-cdk-automation
Copy link
Collaborator

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

3 similar comments
@aws-cdk-automation
Copy link
Collaborator

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

@aws-cdk-automation
Copy link
Collaborator

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

@aws-cdk-automation
Copy link
Collaborator

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

@msambol msambol force-pushed the pipes-targets-sagemaker branch from 73f7e71 to 41d1015 Compare October 16, 2024 19:27
@msambol
Copy link
Contributor Author

msambol commented Oct 16, 2024

@Leo10Gama When you get a chance, another one.. 😅

@msambol
Copy link
Contributor Author

msambol commented Oct 28, 2024

@Leo10Gama have time for this one this week?

@Leo10Gama Leo10Gama self-assigned this Oct 29, 2024
Leo10Gama
Leo10Gama previously requested changes Oct 29, 2024
View reviewed changes
Copy link
Member

@Leo10Gama Leo10Gama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, and sorry about the wait! Overall seems alright, just a few nits. I had one comment regarding using the record instead of an interface, but looking more at the implementation, I think it will lead to a better and more intuitive customer experience.

packages/@aws-cdk/aws-pipes-targets-alpha/lib/sagemaker.ts Show resolved Hide resolved
packages/@aws-cdk/aws-pipes-targets-alpha/lib/sagemaker.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-pipes-targets-alpha/lib/sagemaker.ts Outdated Show resolved Hide resolved
@msambol msambol force-pushed the pipes-targets-sagemaker branch from 341db67 to 45b119c Compare October 30, 2024 01:18
@mergify mergify bot dismissed Leo10Gama’s stale review October 30, 2024 01:19

Pull request has been modified.

@msambol
Copy link
Contributor Author

msambol commented Oct 30, 2024

@Leo10Gama Fixed – thanks for another review!

Leo10Gama
Leo10Gama approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@Leo10Gama Leo10Gama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks again for the contribution! This library is coming together nicely 😄

@Leo10Gama
Copy link
Member

@Mergifyio update

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 30, 2024

update

✅ Branch has been successfully updated

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 30, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 9793fea
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit a5fdf57 into aws:main Oct 30, 2024
13 checks passed
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 30, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@github-actions GitHub Actions
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 30, 2024
@msambol msambol deleted the pipes-targets-sagemaker branch October 30, 2024 22:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nmussy nmussy nmussy requested changes

@Leo10Gama Leo10Gama Leo10Gama approved these changes

Assignees

@Leo10Gama Leo10Gama

Labels
distinguished-contributor [Pilot] contributed 50+ PRs to the CDK p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@msambol @aws-cdk-automation @Leo10Gama @nmussy @pahud