Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ec2): add missing interface vpc endpoints #30807

Merged
merged 4 commits into from
Aug 6, 2024

Conversation

mazyu36
Copy link
Contributor

@mazyu36 mazyu36 commented Jul 9, 2024

Add Eventbridge's missing VPC endpoints.

I identified the missing VPC endpoints using the following procedure:

  1. Retrieved a list of interface endpoints using the command below
% aws ec2 describe-vpc-endpoint-services \
  --filter Name=service-type,Values=Interface \
  --query 'ServiceDetails[].[ServiceName,BaseEndpointDnsNames[0]]' \
  --output json --region us-east-1| jq -r '.[] | @csv'

// result
"aws.api.us-east-1.bcm-data-exports","bcm-data-exports.us-east-1.vpce.amazonaws.com"
"aws.api.us-east-1.freetier","freetier.us-east-1.vpce.amazonaws.com"
"aws.api.us-east-1.kendra-ranking","kendra-ranking.us-east-1.vpce.amazonaws.com"
"aws.api.us-east-1.qbusiness","qbusiness.us-east-1.vpce.amazonaws.com"
// omit
  1. Obtained the differences by comparing the implementation with the list
  2. Verified the differing endpoints exist in the documentation and added them to the implementation

Ref:

Note:

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added p2 star-contributor [Pilot] contributed between 25-49 PRs to the CDK labels Jul 9, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team July 9, 2024 23:56
@mazyu36 mazyu36 changed the title chore(ec2): add missing eventbridg vpc endpoints chore(ec2): add missing eventbridge vpc endpoints Jul 9, 2024
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 10, 2024
@mazyu36 mazyu36 changed the title chore(ec2): add missing eventbridge vpc endpoints chore(ec2): add missing interface vpc endpoints Jul 10, 2024
@@ -316,9 +319,11 @@ export class InterfaceVpcEndpointAwsService implements IInterfaceVpcEndpointServ
public static readonly CLOUDFORMATION = new InterfaceVpcEndpointAwsService('cloudformation');
public static readonly CLOUDHSM = new InterfaceVpcEndpointAwsService('cloudhsmv2');
public static readonly CLOUDTRAIL = new InterfaceVpcEndpointAwsService('cloudtrail');
/** @deprecated Use InterfaceVpcEndpointAwsService.Q_DEVELOPER_CODE_WHISPERER instead.*/
Copy link
Contributor Author

@mazyu36 mazyu36 Jul 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@lpizzinidev lpizzinidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Aug 5, 2024
@shikha372 shikha372 self-assigned this Aug 6, 2024
Copy link
Contributor

mergify bot commented Aug 6, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Aug 6, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: c8ac906
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 292846e into aws:main Aug 6, 2024
13 checks passed
Copy link
Contributor

mergify bot commented Aug 6, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Copy link

github-actions bot commented Aug 6, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2024
@mazyu36 mazyu36 deleted the eventbridg-vpc-endpoints branch August 6, 2024 22:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
p2 star-contributor [Pilot] contributed between 25-49 PRs to the CDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants