-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dynamodb): fix addToResourcePolicy for TableV2 #30909
fix(dynamodb): fix addToResourcePolicy for TableV2 #30909
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
Does this small change qualify for an "Exemption Request"? |
The pull request linter fails with the following errors:
PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing ✅ A exemption request has been requested. Please wait for a maintainer's review. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Comments on closed issues and PRs are hard for our team to see. |
Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one. |
Issue # (if applicable)
Closes #30793
Reason for this change
.addToResourcePolicy()
did not work for TableV2.Description of changes
this.resourcePolicy
is defined in the TableV2 constructor, which appends new statements when.addToResourcePolicy()
is called.Description of how you validated changes
Validated resource policy in CloudFormation template when:
.addToResourcePolicy()
is calledresourcePolicy
property is specified and.addToResourcePolicy()
is calledChecklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license