Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(stepfunctions-tasks): allow passing apiEndpoint as intrinsic function #30954

Closed
wants to merge 10 commits into from
Closed

fix(stepfunctions-tasks): allow passing apiEndpoint as intrinsic function #30954

wants to merge 10 commits into from

Commits on Jul 25, 2024

  1. Use the format intrinsic function to combine the apiRoot and apiEndpo… 

    …int instead of string concatenation. This is required when apiEndpoint requires resolving and isn't just plain text.

Add unit test to cover passing JsonPath.formatted input.
Update integration test.
Update (and fix) README entry's usage example.
    @MathieuGilbert
    MathieuGilbert committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    05015e5 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into awsstepfunctions-httpinvoke-allow-endpoint-f… 

    …ormat
    @MathieuGilbert
    MathieuGilbert committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    135ae3a View commit details
    Browse the repository at this point in the history

  3. Allow destroying the APIGateway RestApi, as there is a check against … 

    …destructive changes: "Stack: aws-stepfunctions-tasks-http-invoke-integ - Resource: IntegRestApiDeploymentD67E59EC852098a1c127ca9d7d16d22086273910 - Impact: WILL_DESTROY"
    @MathieuGilbert
    MathieuGilbert committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    10519df View commit details
    Browse the repository at this point in the history

  4. Allow on the actual resource referenced in the error.

    @MathieuGilbert
    MathieuGilbert committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    e1cbdb1 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'upstream/main' into awsstepfunctions-ht… 

    …tpinvoke-allow-endpoint-format
    @MathieuGilbert
    MathieuGilbert committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    bd250e4 View commit details
    Browse the repository at this point in the history

  6. Try with original "definition" prop, and without allowDestroy.

    @MathieuGilbert
    MathieuGilbert committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    41f8207 View commit details
    Browse the repository at this point in the history

  7. It still neds the deployment

    @MathieuGilbert
    MathieuGilbert committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    8c032fd View commit details
    Browse the repository at this point in the history

  8. Make the expectation more meaningful.

    @MathieuGilbert
    MathieuGilbert committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    f311023 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2024

  1. Might as well use the current syntax; this didn't affect the integrat… 

    …ion test failure.
    @MathieuGilbert
    MathieuGilbert committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    e37458f View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2024

  1. Merge remote-tracking branch 'upstream/main' into awsstepfunctions-ht… 

    …tpinvoke-allow-endpoint-format
    @MathieuGilbert
    MathieuGilbert committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    54e62bf View commit details
    Browse the repository at this point in the history