Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws-codepipeline-actions): use SecretValue #3097

Merged
merged 1 commit into from
Jun 27, 2019
Merged

fix(aws-codepipeline-actions): use SecretValue #3097

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/@aws-cdk/aws-codepipeline-actions/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ To use GitHub as the source of a CodePipeline:

```typescript
// Read the secret from ParameterStore
const token = new cdk.SecretParameter(this, 'GitHubToken', { ssmParameter: 'my-github-token' });
const token = cdk.SecretValue.ssmSecure('my-github-token','1');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, we have a problem here. CodePipeline does not accept SSM Secure parameters (only Plain Text ones), and trying to deploy with it results in an error like:

 ❌  Pipeline failed: ValidationError: SSM Secure reference is not supported in: 
[AWS::CodePipeline::Pipeline/Properties/Stages,AWS::CodePipeline::Webhook/Properties/AuthenticationConfiguration/SecretToken]

We need to change this example to use cdk.SecretValue.secretsManager().

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR: #3113

const sourceOutput = new codepipeline.Artifact();
const sourceAction = new codepipeline_actions.GitHubSourceAction({
actionName: 'GitHub_Source',
Expand Down