Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rds): add support for aurora-postgresql 16.3 #31003

Merged
merged 3 commits into from
Aug 5, 2024

Conversation

Andrwe
Copy link
Contributor

@Andrwe Andrwe commented Aug 1, 2024

Reason for this change

Add support for newly supported aurora-postgresql16 16.3.

Description of changes

Add a new version as a new property to AuroraPostgresEngineVersion class. (see https://docs.aws.amazon.com/AmazonRDS/latest/PostgreSQLReleaseNotes/postgresql-versions.html)
The change already happened with #30242 and was reverted by #30296 as the version was not available.

Description of how you validated changes

The version 16.3 is available now:

$ aws rds describe-db-engine-versions --engine aurora-postgresql --query "DBEngineVersions[?EngineVersion=='16.3']"
[
    {
        "Engine": "aurora-postgresql",
        "EngineVersion": "16.3",
        "DBParameterGroupFamily": "aurora-postgresql16",
        "DBEngineDescription": "Aurora (PostgreSQL)",
        "DBEngineVersionDescription": "Aurora PostgreSQL (Compatible with PostgreSQL 16.3)",
        "ValidUpgradeTarget": [],
        "ExportableLogTypes": [
            "postgresql"
        ],
        "SupportsLogExportsToCloudwatchLogs": true,
        "SupportsReadReplica": false,
        "SupportedEngineModes": [
            "provisioned"
        ],
        "SupportedFeatureNames": [
            "Comprehend",
            "Lambda",
            "s3Export",
            "s3Import",
            "SageMaker"
        ],
        "Status": "available",
        "SupportsParallelQuery": false,
        "SupportsGlobalDatabases": true,
        "MajorEngineVersion": "16",
        "SupportsBabelfish": true,
        "SupportsLimitlessDatabase": false,
        "SupportsCertificateRotationWithoutRestart": true,
        "SupportedCACertificateIdentifiers": [
            "rds-ca-2019",
            "rds-ca-ecc384-g1",
            "rds-ca-rsa4096-g1",
            "rds-ca-rsa2048-g1"
        ],
        "SupportsLocalWriteForwarding": true,
        "SupportsIntegrations": false
    }
]

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Signed-off-by: Andreas Ulm <andreas.ulm@prisma-capacity.eu>
@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Aug 1, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team August 1, 2024 13:11
@github-actions github-actions bot added the p2 label Aug 1, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@Andrwe
Copy link
Contributor Author

Andrwe commented Aug 1, 2024

Exemption Request

I request an exemption from the rules regarding README and integration tests as this PR only adds support for a new version of AuroraPostgresEngineVersion to be up-to-date to versions supported by AWS Aurora service.
Therefore no functionality is added, changed or removed that IMHO needs additional testing.

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Aug 1, 2024
@Andrwe Andrwe changed the title feat(rds): add support for aurora-postgresql 16.3 chore(rds): add support for aurora-postgresql 16.3 Aug 5, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review August 5, 2024 08:47

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

Copy link
Contributor

mergify bot commented Aug 5, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: e5cc57f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 3670d83 into aws:main Aug 5, 2024
9 checks passed
Copy link
Contributor

mergify bot commented Aug 5, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Copy link

github-actions bot commented Aug 5, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2024
@Andrwe Andrwe deleted the add_pgsql_version_VER_16_3 branch August 6, 2024 05:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants