fix(lambda): validate localMountPath format and length #31019
Conversation
github-actions
bot
added
the
beginning-contributor
github-actions
bot
added
bug
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
|
I think integration test is overkill for this PR |
|
Exemption Request |
aws-cdk-automation
added
pr-linter/exemption-requested
| code: lambda.Code.fromAsset(path.join(__dirname, 'handler.zip')), | ||
| filesystem: lambda.FileSystem.fromEfsAccessPoint(accessPoint, '/not-mnt/foo-bar'), | ||
| }); | ||
| }).toThrow(); |
There was a problem hiding this comment.
bit of a nick pick, but do you think it would be a good idea to add the actual error message? We could check that the correct error is being thrown out, rather than just an error being thrown?
| code: lambda.Code.fromAsset(path.join(__dirname, 'handler.zip')), | ||
| filesystem: lambda.FileSystem.fromEfsAccessPoint(accessPoint, `/mnt/${'a'.repeat(160)}`), | ||
| }); | ||
| }).toThrow(); |
There was a problem hiding this comment.
Same here, would be a good idea to test against the actual error message.
aws-cdk-automation
removed
the
pr/needs-community-review
moelasmar
added
pr-linter/exempt-integ-test
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
mergify
bot
dismissed
moelasmar’s stale review
Pull request has been modified.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #17526
Reason for this change
Show user-friendly error message faster (before deployment)
Description of changes
Added format and length validation according to AWS::Lambda::Function FileSystemConfig document
Description of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license