chore: use externally published version of cdk-assets #31119
Conversation
TheRealAmazonKendra
added
the
pr/do-not-merge
|
Adding do-not-merge label while I run this through the test pipeline. |
aws-cdk-automation
added
the
pr/needs-maintainer-review
TheRealAmazonKendra
removed
the
pr/do-not-merge
|
Removed the label as it passed the pipeline. |
| - packages/aws-cdk-lib/cloud-assembly-schema/schema/** | ||
| - packages/aws-cdk-lib/cloud-assembly-schema/scripts/** | ||
| - packages/aws-cdk-lib/cloud-assembly-schema/test/** |
There was a problem hiding this comment.
Cloud assembly schema is removed from here (and a few other places), but this PR doesn't delete that package and the title doesn't suggest that we're using the externally published version of cloud-assembly-schema as well. Can we update the PR title to reflect that?
There was a problem hiding this comment.
Cloud assembly schema was removed in a previous PR.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
This PR only includes the removal of cdk-assets. In order to keep PRs small and clean, this does not include the documentation updates for how to find and contribute to cdk-assets for cloud-assembly-schema. That will be a separate PR.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license