feat(codebuild): support three arm-based compute types, Medium, X-Large and 2X-Large #31214

mazyu36 · 2024-08-25T14:55:13Z

Issue # (if applicable)

Closes #30869.

Reason for this change

Because three new arm-based compute types have become supported due to an update.

Announcement: AWS CodeBuild now supports three new Arm-based compute types

Description of changes

Modify the validate method to allow Medium, X-Large, and 2X-Large as Arm-based compute types.

Description of how you validated changes

Modify unit tests and integ tests.

Checklist

My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

…ge and 2X-Large

mazyu36 · 2024-08-25T14:56:43Z

packages/aws-cdk-lib/aws-codebuild/test/codebuild.test.ts

@@ -1751,12 +1751,12 @@ describe('Linux x86-64 Image', () => {
 });

 describe('ARM image', () => {
-  describe('AMAZON_LINUX_2_ARM', () => {


Since ARM_LINUX2_ARM is deprecated, I took the opportunity to update it as well.

aws-cdk-automation

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

mazyu36 · 2024-08-25T14:57:44Z

packages/aws-cdk-lib/aws-codebuild/test/codebuild.test.ts

@@ -1815,17 +1820,39 @@ describe('ARM image', () => {
      });
    });

-    test('cannot be used in conjunction with ComputeType X2_LARGE', () => {
+    test('can be used with ComputeType X_LARGE', () => {


A unit test for X_LARGE was missing, so I've added.

mazyu36 · 2024-08-25T14:58:03Z

packages/aws-cdk-lib/aws-codebuild/test/linux-arm-build-image.test.ts

@@ -68,17 +73,39 @@ describe('Linux ARM build image', () => {
      });
    });

-    test('cannot be used in conjunction with ComputeType X2_LARGE', () => {
+    test('can be used with ComputeType X_LARGE', () => {


A unit test for X_LARGE was missing, so I've added.

mazyu36 · 2024-08-25T14:58:14Z

packages/aws-cdk-lib/aws-codebuild/test/linux-arm-build-image.test.ts

@@ -146,17 +178,39 @@ describe('Linux ARM build image', () => {
      });
    });

-    test('cannot be used in conjunction with ComputeType X2_LARGE', () => {
+    test('can be used with ComputeType X_LARGE', () => {


A unit test for X_LARGE was missing, so I've added.

mazyu36 · 2024-08-25T14:58:25Z

packages/aws-cdk-lib/aws-codebuild/test/linux-arm-build-image.test.ts

@@ -224,17 +283,39 @@ describe('Linux ARM build image', () => {
      });
    });

-    test('cannot be used in conjunction with ComputeType X2_LARGE', () => {
+    test('can be used with ComputeType X_LARGE', () => {


A unit test for X_LARGE was missing, so I've added.

mazyu36 · 2024-08-25T15:01:06Z

packages/aws-cdk-lib/aws-codebuild/test/linux-arm-build-image.test.ts

@@ -38,17 +38,22 @@ describe('Linux ARM build image', () => {
      });
    });

-    test('cannot be used in conjunction with ComputeType MEDIUM', () => {
+    test('can be used with ComputeType MEDIUM', () => {


Although AMAZON_LINUX_2_STANDARD_1_0 is deprecated, there are tests implemented for STANDARD_1_0, so I decided to keep it as I considered removing it inappropriate.
If you think it would be better to remove it, please let me know.

mazyu36 · 2024-08-25T15:02:53Z

Exemption Request: As this is only a modification to the validate method and there are no changes affecting the README, I think an update to the README is unnecessary.

scanlonp

Looks good. Thanks for the contribution!

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

mergify · 2024-08-26T19:28:41Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Pull request has been modified.

scanlonp · 2024-08-26T23:56:50Z

@Mergifyio update

mergify · 2024-08-26T23:56:57Z

update

☑️ Nothing to do

#commits-behind>0 [📌 update requirement]
-closed [📌 update requirement]
-conflict [📌 update requirement]
queue-position=-1 [📌 update requirement]

scanlonp · 2024-08-27T00:04:04Z

@Mergifyio refresh

mergify · 2024-08-27T00:04:09Z

refresh

✅ Pull request refreshed

scanlonp · 2024-08-27T00:05:33Z

Hey @mazyu36, apologies for the noise. The build failed on a test with a race condition. Trying to re-run the build so that the PR can be merged.

scanlonp

Trigger codebuild.

Pull request has been modified.

mazyu36 · 2024-08-27T13:34:03Z

@scanlonp
Thank you for your help. Could you please approve again?

mergify · 2024-08-29T19:48:41Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

aws-cdk-automation · 2024-08-29T20:20:25Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: 1de3f2f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2024-08-29T20:20:45Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

github-actions · 2024-08-29T20:21:00Z

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

feat(codebuild): support three arm-based compute types, Medium, X-Lar…

601ad14

…ge and 2X-Large

aws-cdk-automation requested a review from a team August 25, 2024 14:55

github-actions bot added bug This issue is a bug. p2 distinguished-contributor [Pilot] contributed 50+ PRs to the CDK labels Aug 25, 2024

mazyu36 commented Aug 25, 2024

View reviewed changes

aws-cdk-automation previously requested changes Aug 25, 2024

View reviewed changes

mazyu36 commented Aug 25, 2024

View reviewed changes

aws-cdk-automation added pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Aug 25, 2024

github-actions bot mentioned this pull request Aug 26, 2024

Weekly PR metrics report #31217

Closed

scanlonp previously approved these changes Aug 26, 2024

View reviewed changes

scanlonp added pr-linter/exempt-readme The PR linter will not require README changes and removed pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. labels Aug 26, 2024

aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Aug 26, 2024

Merge branch 'main' into codebuild-project-30869

46c5f0e

scanlonp approved these changes Aug 26, 2024

View reviewed changes

scanlonp requested changes Aug 27, 2024

View reviewed changes

scanlonp previously approved these changes Aug 27, 2024

View reviewed changes

retrigger checks

6c4ef2a

mazyu36 requested a review from scanlonp August 27, 2024 13:34

scanlonp approved these changes Aug 29, 2024

View reviewed changes

Merge branch 'main' into codebuild-project-30869

1de3f2f

mergify bot merged commit 39492e9 into aws:main Aug 29, 2024
9 checks passed

github-actions bot locked as resolved and limited conversation to collaborators Aug 29, 2024

mazyu36 deleted the codebuild-project-30869 branch August 29, 2024 22:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(codebuild): support three arm-based compute types, Medium, X-Large and 2X-Large #31214

feat(codebuild): support three arm-based compute types, Medium, X-Large and 2X-Large #31214

mazyu36 commented Aug 25, 2024 •

edited

Loading

mazyu36 Aug 25, 2024

aws-cdk-automation left a comment

mazyu36 Aug 25, 2024

mazyu36 Aug 25, 2024

mazyu36 Aug 25, 2024

mazyu36 Aug 25, 2024

mazyu36 Aug 25, 2024

mazyu36 commented Aug 25, 2024

scanlonp left a comment

mergify bot commented Aug 26, 2024

scanlonp commented Aug 26, 2024

mergify bot commented Aug 26, 2024

scanlonp commented Aug 27, 2024

mergify bot commented Aug 27, 2024

scanlonp commented Aug 27, 2024

scanlonp left a comment

mazyu36 commented Aug 27, 2024

mergify bot commented Aug 29, 2024

aws-cdk-automation commented Aug 29, 2024

mergify bot commented Aug 29, 2024

github-actions bot commented Aug 29, 2024

feat(codebuild): support three arm-based compute types, Medium, X-Large and 2X-Large #31214

feat(codebuild): support three arm-based compute types, Medium, X-Large and 2X-Large #31214

Conversation

mazyu36 commented Aug 25, 2024 • edited Loading

Issue # (if applicable)

Reason for this change

Description of changes

Description of how you validated changes

Checklist

mazyu36 Aug 25, 2024

Choose a reason for hiding this comment

aws-cdk-automation left a comment

Choose a reason for hiding this comment

mazyu36 Aug 25, 2024

Choose a reason for hiding this comment

mazyu36 Aug 25, 2024

Choose a reason for hiding this comment

mazyu36 Aug 25, 2024

Choose a reason for hiding this comment

mazyu36 Aug 25, 2024

Choose a reason for hiding this comment

mazyu36 Aug 25, 2024

Choose a reason for hiding this comment

mazyu36 commented Aug 25, 2024

scanlonp left a comment

Choose a reason for hiding this comment

mergify bot commented Aug 26, 2024

scanlonp commented Aug 26, 2024

mergify bot commented Aug 26, 2024

☑️ Nothing to do

scanlonp commented Aug 27, 2024

mergify bot commented Aug 27, 2024

✅ Pull request refreshed

scanlonp commented Aug 27, 2024

scanlonp left a comment

Choose a reason for hiding this comment

mazyu36 commented Aug 27, 2024

mergify bot commented Aug 29, 2024

aws-cdk-automation commented Aug 29, 2024

AWS CodeBuild CI Report

mergify bot commented Aug 29, 2024

github-actions bot commented Aug 29, 2024

mazyu36 commented Aug 25, 2024 •

edited

Loading