chore: format expected output #31235
Conversation
TheRealAmazonKendra
temporarily deployed
to
test-pipeline
GitHub Actions
Inactive
This sometimes works in our pipeline and sometimes works locally without the formatting.
I'm not actually particularly sure why, but adding in the expected formatting should make this pass reliably.
NOTE: When I ran yarn lint --fix after the linter failed, it did a lot more formatitng than expected.
The only actual non-formatting changes to this file are in the last test on lines 2078 through 2099.
TheRealAmazonKendra
force-pushed
the
TheRealAmazonKendra/extend-timeout
branch
from
0c85e59
to
da13f03
Compare
TheRealAmazonKendra
temporarily deployed
to
test-pipeline
GitHub Actions
Inactive
|
➡️ PR build request submitted to A maintainer must now check the pipeline and add the |
aws-cdk-automation
added
the
pr/needs-maintainer-review
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
| expect( | ||
| await fixture.cdkSynth({ | ||
| options: [fixture.fullStackName('test-1')], | ||
| }), | ||
| ).not.toEqual( | ||
| expect.stringContaining(` | ||
| Rules: | ||
| CheckBootstrapVersion:`)); | ||
| CheckBootstrapVersion:`), | ||
| ); |
There was a problem hiding this comment.
Some of these formatting changes make this worse to read, like this one.
| expect(fixture.template('test-2')).toEqual( | ||
| expect.objectContaining({ |
There was a problem hiding this comment.
Do these have to go on different lines? This was easier to read before
aws-cdk-automation
removed
the
pr/needs-maintainer-review
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
This test (hotswap deployment for ecs service detects failed deployment and errors) sometimes works in our pipeline and sometimes works locally without the formatting. Sometimes it fails.
I'm not actually particularly sure why, but adding in the expected formatting should make this pass reliably.
NOTE: When I ran yarn lint --fix after the linter failed in
cli.integtest.ts, it did a lot more formatting than expected.The only actual non-formatting changes to this file are in the last test on lines 2078 through 2099.
Issue # (if applicable)
Closes #.
Reason for this change
Description of changes
Description of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license