fix: pipelines ties cli version with cdk-assets version #31261
Conversation
github-actions
bot
added
bug
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
| this.cliVersion = props.cliVersion ?? preferredCliVersion(); | ||
| this.cliVersion = props.cliVersion ?? 'latest'; |
There was a problem hiding this comment.
If you are sure it is safe to unlock all CLI versions (both aws-cdk and cdk-assets), then remove the this.cliVersion property entirely.
Otherwise, keep the versioning on aws-cdk and remove its use only for cdk-assets.
comcalvi
added
the
pr-linter/exempt-integ-test
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
comcalvi
removed
the
pr-linter/exempt-integ-test
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
comcalvi
added
the
pr-linter/exempt-integ-test
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
cdk-assets is no longer being versioned in line with the cli or with aws-cdk-lib. Because every change must be backward compatible, we can just use
latestfor cdk-assets (not that we will soon be releasing a new major version of cdk-assets but we are releasing that with thev3-latesttag at present. When we are ready to swap versions, we will begin labeling the v3 line aslatestand make the v2 linev2-latestas it will be in maintenance mode.Note: the linter and potentially the build will fail for this initially because an integ test needs to be updated.
Closes #31253.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license