Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stepfunctions-tasks): add back BedrockInvokeModel to use JsonPath #31325

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

shikha372
Copy link
Contributor

Reverts #31308

After discussion with the team, we are working on the "roll-forward fix" PR for this issue and not going ahead with this revert
#31305

Reverting to resolve the existing conflicts.

@github-actions github-actions bot added the p2 label Sep 4, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team September 4, 2024 23:07
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Sep 4, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@shikha372 shikha372 changed the title Revert "revert(stepfunctions-tasks): "feat(stepfunctions-tasks): allow BedrockInvokeModel to use JsonPath"" fix(stepfunctions-tasks): "add backfeat(stepfunctions-tasks): allow BedrockInvokeModel to use JsonPath Sep 4, 2024
@Leo10Gama Leo10Gama changed the title fix(stepfunctions-tasks): "add backfeat(stepfunctions-tasks): allow BedrockInvokeModel to use JsonPath revert: "revert(stepfunctions-tasks): "feat(stepfunctions-tasks): allow BedrockInvokeModel to use JsonPath"" Sep 4, 2024
@shikha372 shikha372 changed the title revert: "revert(stepfunctions-tasks): "feat(stepfunctions-tasks): allow BedrockInvokeModel to use JsonPath"" fix(stepfunctions-tasks): add back BedrockInvokeModel to use JsonPath Sep 4, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review September 4, 2024 23:11

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

Copy link
Contributor

mergify bot commented Sep 4, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@shikha372 shikha372 marked this pull request as ready for review September 4, 2024 23:45
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 07e54f6
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 5b059b9 into main Sep 5, 2024
11 of 12 checks passed
Copy link
Contributor

mergify bot commented Sep 5, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot deleted the revert-31308-revert-30298-s3_uri_for_bedrock branch September 5, 2024 00:28
Copy link

github-actions bot commented Sep 5, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants