-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(kinesisanalytics-flink): support Apache Flink 1.20 #31349
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,21 +21,32 @@ describe('Application', () => { | |
stack = new core.Stack(); | ||
bucket = new s3.Bucket(stack, 'CodeBucket'); | ||
requiredProps = { | ||
runtime: flink.Runtime.FLINK_1_19, | ||
runtime: flink.Runtime.FLINK_1_20, | ||
code: flink.ApplicationCode.fromBucket(bucket, 'my-app.jar'), | ||
}; | ||
}); | ||
|
||
test('default Flink Application', () => { | ||
const flinkRuntimes = [ | ||
flink.Runtime.FLINK_1_6, | ||
flink.Runtime.FLINK_1_8, | ||
flink.Runtime.FLINK_1_11, | ||
flink.Runtime.FLINK_1_13, | ||
flink.Runtime.FLINK_1_15, | ||
flink.Runtime.FLINK_1_18, | ||
flink.Runtime.FLINK_1_19, | ||
flink.Runtime.FLINK_1_20, | ||
]; | ||
|
||
test.each(flinkRuntimes)('Flink Application with %s', (runtime) => { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Improved to test all runtimes |
||
new flink.Application(stack, 'FlinkApplication', { | ||
runtime: flink.Runtime.FLINK_1_19, | ||
runtime, | ||
code: flink.ApplicationCode.fromBucket(bucket, 'my-app.jar'), | ||
applicationName: 'MyFlinkApplication', | ||
}); | ||
|
||
Template.fromStack(stack).hasResourceProperties('AWS::KinesisAnalyticsV2::Application', { | ||
ApplicationName: 'MyFlinkApplication', | ||
RuntimeEnvironment: 'FLINK-1_19', | ||
RuntimeEnvironment: runtime.value, | ||
ServiceExecutionRole: { | ||
'Fn::GetAtt': [ | ||
'FlinkApplicationRole2F7BCBF6', | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update row 83 as well for consistency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Updated.