-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cognito): deprecate privateKey and add privateKeyValue as typed SecureValue #31409
fix(cognito): deprecate privateKey and add privateKeyValue as typed SecureValue #31409
Conversation
packages/aws-cdk-lib/aws-cognito/test/user-pool-idps/apple.test.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
Exemption Request |
Have you tested this by deploying to CFN? |
Unfortunately I don't have a valid private_key for that. And there's no existing integ test for that as well so I am offering unit tests only.
|
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #31378
Reason for this change
privateKey
was typedstring
which should beSecureValue
just as clientSecretValue in Google IdP. This PR deprecatesprivateKey
and addsprivateKeyValue
with correct type.apple.ts
was named by mistake and it won't be unit tested. This PR renames it toapple.test.ts
so it would be covered. Figured an existing test was failed, just fixed that failed one as well.Description of changes
privateKeyValue
property of type SecretValue to UserPoolIdentityProviderApplePropsprivateKey
string propertyprivateKey
orprivateKeyValue
is providedprivateKeyValue
when availableUsers must now provide either
privateKey
orprivateKeyValue
,but not both. This change enhances security by allowing the use of SecretValue
for the Apple IDP private key.
Description of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license